Code review comment for lp:~surfacepatterns/ubuntu/quantal/rtmidi/add-alsa-support

Revision history for this message
Devin Anderson (surfacepatterns) wrote :

Hi Oliver,

On Thu, Jan 24, 2013 at 5:59 AM, Oliver Grawert <email address hidden> wrote:

> while the patch itself does not look harmful, how about the binaries
> this produces, have they been tested to not have regressions in the
> context they are usually used ?

I've tested the changes against `midisnoop`, an application I wrote to
monitor and probe MIDI ports. Using `midisnoop`, I've done the
following with both the JACK and ALSA drivers:

    * opened and closed MIDI ports, both named and virtual

    * sent and received MIDI messages, including system exclusive messages
    (some of which the JACK driver doesn't handle due to the limitations of
    JACK MIDI)

    * switching back and forth between the JACK and ALSA drivers multiple
    times during the same execution

All of the code that interacts with the RtMidi library can be found here:

    https://code.google.com/p/midisnoop/source/browse/src/engine.cpp

... and here:

    https://code.google.com/p/midisnoop/source/browse/src/engine.h

> since this is a merge request for quantal
> (https://wiki.ubuntu.com/StableReleaseUpdates) can you:
>
> a) file an SRU bug according to the above process
> b) prepare the same patch for raring (13.04) since SRUs
> require that the code is in the development release first

I can, but I don't know when I'll find time to do it.

Thanks,

--
Devin Anderson
surfacepatterns (at) gmail (dot) com

blog - http://surfacepatterns.blogspot.com/
midisnoop - http://midisnoop.googlecode.com/
psinsights - http://psinsights.googlecode.com/
synthclone - http://synthclone.googlecode.com/

« Back to merge proposal