Merge ~suligap/snapstore-client:core22-as-base-in-offline-install-bundle into snapstore-client:main

Proposed by Przemysław Suliga
Status: Merged
Approved by: Przemysław Suliga
Approved revision: ab19eaaa91353c43923c36b9957473637e435bba
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~suligap/snapstore-client:core22-as-base-in-offline-install-bundle
Merge into: snapstore-client:main
Diff against target: 63 lines (+9/-9)
3 files modified
store_admin/__init__.py (+1/-1)
store_admin/logic/registration.py (+3/-3)
store_admin/logic/tests/test_registration.py (+5/-5)
Reviewer Review Type Date Requested Status
Bowen Fan Approve
Review via email: mp+442005@code.launchpad.net

Commit message

Bundle core22 as base in offline install bundle

snap-store-proxy is moving to core22 as a base. core20 is installed by
default on Focal and newer images and Focal is minimum required for
snap-store-proxy now.

To post a comment you must log in.
Revision history for this message
Bowen Fan (bowenfan) wrote :

LGTM with a small question, thank you!

review: Approve
Revision history for this message
Przemysław Suliga (suligap) wrote :

Thanks Bowen!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/store_admin/__init__.py b/store_admin/__init__.py
index 35ec9a3..2238c8f 100644
--- a/store_admin/__init__.py
+++ b/store_admin/__init__.py
@@ -1 +1 @@
1version = "1.3.1"1version = "1.3.2"
diff --git a/store_admin/logic/registration.py b/store_admin/logic/registration.py
index 79f907c..c0ec62d 100644
--- a/store_admin/logic/registration.py
+++ b/store_admin/logic/registration.py
@@ -21,8 +21,8 @@ logger = logging.getLogger(__name__)
21INSTALL = """#!/bin/bash21INSTALL = """#!/bin/bash
22set -eu22set -eu
23[ $(id -u) = "0" ] || (echo "Please run this script as root or with sudo." && exit 1)23[ $(id -u) = "0" ] || (echo "Please run this script as root or with sudo." && exit 1)
24snap ack core20_*.assert24snap ack core22_*.assert
25snap install core20_*.snap25snap install core22_*.snap
26snap ack snapd_*.assert26snap ack snapd_*.assert
27snap install snapd_*.snap27snap install snapd_*.snap
28snap ack snap-store-proxy_*.assert28snap ack snap-store-proxy_*.assert
@@ -190,7 +190,7 @@ def make_bundle(session, data, output, channel, arch):
190 bundle_dir.mkdir()190 bundle_dir.mkdir()
191191
192 # Add snap binaries and assertions to the offline bundle.192 # Add snap binaries and assertions to the offline bundle.
193 for snap_name in ["core20", "snapd", "snap-store-proxy"]:193 for snap_name in ["core22", "snapd", "snap-store-proxy"]:
194 download_snap_files(194 download_snap_files(
195 defaults.get_devicegw_url(),195 defaults.get_devicegw_url(),
196 session,196 session,
diff --git a/store_admin/logic/tests/test_registration.py b/store_admin/logic/tests/test_registration.py
index 5f85b85..2321789 100644
--- a/store_admin/logic/tests/test_registration.py
+++ b/store_admin/logic/tests/test_registration.py
@@ -316,13 +316,13 @@ def test_make_bundle(
316 include_metadata=False,316 include_metadata=False,
317 file_read_cb=snaps.progress_copy_to_file,317 file_read_cb=snaps.progress_copy_to_file,
318 )318 )
319 for snap_name in ["core20", "snapd", "snap-store-proxy"]319 for snap_name in ["core22", "snapd", "snap-store-proxy"]
320 ]320 ]
321 assert mock_download_snap_files.call_args_list == expected_calls321 assert mock_download_snap_files.call_args_list == expected_calls
322 assert tar_members_by_name.keys() == {322 assert tar_members_by_name.keys() == {
323 "offline-snap-store",323 "offline-snap-store",
324 "offline-snap-store/core20.assert",324 "offline-snap-store/core22.assert",
325 "offline-snap-store/core20.snap",325 "offline-snap-store/core22.snap",
326 "offline-snap-store/install.sh",326 "offline-snap-store/install.sh",
327 "offline-snap-store/proxy.assert",327 "offline-snap-store/proxy.assert",
328 "offline-snap-store/snap-store-proxy.assert",328 "offline-snap-store/snap-store-proxy.assert",
@@ -337,8 +337,8 @@ def test_make_bundle(
337 == b"""#!/bin/bash337 == b"""#!/bin/bash
338set -eu338set -eu
339[ $(id -u) = "0" ] || (echo "Please run this script as root or with sudo." && exit 1)339[ $(id -u) = "0" ] || (echo "Please run this script as root or with sudo." && exit 1)
340snap ack core20_*.assert340snap ack core22_*.assert
341snap install core20_*.snap341snap install core22_*.snap
342snap ack snapd_*.assert342snap ack snapd_*.assert
343snap install snapd_*.snap343snap install snapd_*.snap
344snap ack snap-store-proxy_*.assert344snap ack snap-store-proxy_*.assert

Subscribers

People subscribed via source and target branches

to all changes: