Merge ~suligap/snapstore-client:core22-as-base-in-offline-install-bundle into snapstore-client:main

Proposed by Przemysław Suliga
Status: Merged
Approved by: Przemysław Suliga
Approved revision: ab19eaaa91353c43923c36b9957473637e435bba
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~suligap/snapstore-client:core22-as-base-in-offline-install-bundle
Merge into: snapstore-client:main
Diff against target: 63 lines (+9/-9)
3 files modified
store_admin/__init__.py (+1/-1)
store_admin/logic/registration.py (+3/-3)
store_admin/logic/tests/test_registration.py (+5/-5)
Reviewer Review Type Date Requested Status
Bowen Fan Approve
Review via email: mp+442005@code.launchpad.net

Commit message

Bundle core22 as base in offline install bundle

snap-store-proxy is moving to core22 as a base. core20 is installed by
default on Focal and newer images and Focal is minimum required for
snap-store-proxy now.

To post a comment you must log in.
Revision history for this message
Bowen Fan (bowenfan) wrote :

LGTM with a small question, thank you!

review: Approve
Revision history for this message
Przemysław Suliga (suligap) wrote :

Thanks Bowen!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/store_admin/__init__.py b/store_admin/__init__.py
2index 35ec9a3..2238c8f 100644
3--- a/store_admin/__init__.py
4+++ b/store_admin/__init__.py
5@@ -1 +1 @@
6-version = "1.3.1"
7+version = "1.3.2"
8diff --git a/store_admin/logic/registration.py b/store_admin/logic/registration.py
9index 79f907c..c0ec62d 100644
10--- a/store_admin/logic/registration.py
11+++ b/store_admin/logic/registration.py
12@@ -21,8 +21,8 @@ logger = logging.getLogger(__name__)
13 INSTALL = """#!/bin/bash
14 set -eu
15 [ $(id -u) = "0" ] || (echo "Please run this script as root or with sudo." && exit 1)
16-snap ack core20_*.assert
17-snap install core20_*.snap
18+snap ack core22_*.assert
19+snap install core22_*.snap
20 snap ack snapd_*.assert
21 snap install snapd_*.snap
22 snap ack snap-store-proxy_*.assert
23@@ -190,7 +190,7 @@ def make_bundle(session, data, output, channel, arch):
24 bundle_dir.mkdir()
25
26 # Add snap binaries and assertions to the offline bundle.
27- for snap_name in ["core20", "snapd", "snap-store-proxy"]:
28+ for snap_name in ["core22", "snapd", "snap-store-proxy"]:
29 download_snap_files(
30 defaults.get_devicegw_url(),
31 session,
32diff --git a/store_admin/logic/tests/test_registration.py b/store_admin/logic/tests/test_registration.py
33index 5f85b85..2321789 100644
34--- a/store_admin/logic/tests/test_registration.py
35+++ b/store_admin/logic/tests/test_registration.py
36@@ -316,13 +316,13 @@ def test_make_bundle(
37 include_metadata=False,
38 file_read_cb=snaps.progress_copy_to_file,
39 )
40- for snap_name in ["core20", "snapd", "snap-store-proxy"]
41+ for snap_name in ["core22", "snapd", "snap-store-proxy"]
42 ]
43 assert mock_download_snap_files.call_args_list == expected_calls
44 assert tar_members_by_name.keys() == {
45 "offline-snap-store",
46- "offline-snap-store/core20.assert",
47- "offline-snap-store/core20.snap",
48+ "offline-snap-store/core22.assert",
49+ "offline-snap-store/core22.snap",
50 "offline-snap-store/install.sh",
51 "offline-snap-store/proxy.assert",
52 "offline-snap-store/snap-store-proxy.assert",
53@@ -337,8 +337,8 @@ def test_make_bundle(
54 == b"""#!/bin/bash
55 set -eu
56 [ $(id -u) = "0" ] || (echo "Please run this script as root or with sudo." && exit 1)
57-snap ack core20_*.assert
58-snap install core20_*.snap
59+snap ack core22_*.assert
60+snap install core22_*.snap
61 snap ack snapd_*.assert
62 snap install snapd_*.snap
63 snap ack snap-store-proxy_*.assert

Subscribers

People subscribed via source and target branches

to all changes: