Canonical SSO provider

Code review comment for lp:~suligap/canonical-identity-provider/charm-de-oops

  1. charm-de-oops
  2. Merge into charm
Revision history for this message
Przemysław Suliga (suligap) wrote :

Thanks!

FWIW, here's the spec MP: https://code.launchpad.net/~suligap/canonical-mojo-specs/mojo-ols-canonical-identity-provider-de-oops/+merge/385258.

I wonder if it's enough to just do:

1. Land the spec, local.yaml changes.
2. Land this MP.

Since in this charm we only use these config options in templates and unit tests? (and that's what's being removed here apart from the config options themselves.) I'm probably missing something.

« Back to merge proposal