Code review comment for ~sudipmuk/ubuntu/+source/zeitgeist:merge-lp2044300-noble

Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

Hi Simon,

On Wed, 29 Nov 2023 at 18:37, Simon Chopin <email address hidden> wrote:
>
> Hi!
>
> Thank you for the contribution, and for following up on Utkarsh's review.
>
> Luckily, the person that did the 0.9.14-0ubuntu1 (ricotz) is still around, so I asked them directly what this was for: https://irclogs.ubuntu.com/2023/11/29/%23ubuntu-devel.html#t14:12

Thanks for following up with Rico.

>
> TL;DR: we're not sure why the patch exists, and it's likely it's not needed anymore.
>
> Would you be willing to test a version with that patch dropped?

I have dropped the patch "add_datahub_autostart_delay.patch" and
tested on a Noble installation and did not notice any problem.
And so the branch is now updated and also pushed to new PPA at
https://launchpad.net/~sudipmuk/+archive/ubuntu/zeitgeist-merge-1/

--
Regards
Sudip

« Back to merge proposal