Code review comment for ~sudipmuk/ubuntu/+source/libtrace3:merge-3.0.22-0.1-noble

Revision history for this message
Aaron Rainbolt (arraybolt3) wrote :

The delta is Lintian-clean and the changes look good to me.

The package *does* have an awful lot of Lintian tags shown when building, the relevant ones being:

W: libtrace3 source: build-depends-on-obsolete-package Build-Depends: libncurses5-dev => libncurses-dev
W: libtrace3 source: dh-clean-k-is-deprecated [debian/rules]
W: libtrace-tools: no-manual-page [usr/bin/wandiocat]
W: libtrace3 source: no-versioned-debhelper-prerequisite 7
W: libtrace3 source: package-uses-deprecated-debhelper-compat-version 7
I: libtrace3 source: debian-watch-file-is-missing
I: libtrace3 source: installable-field-mirrors-source (in section for libpacketdump3v5) Section [debian/control:60]
I: libtrace3 source: installable-field-mirrors-source (in section for libtrace3) Section [debian/control:30]
I: libtrace3 source: installable-field-mirrors-source (in section for libwandio1) Section [debian/control:88]
I: libtrace3 source: no-dh-sequencer [debian/rules]
I: libpacketdump3v5: no-symbols-control-file usr/lib/libpacketdump.so.3.0.22
I: libtrace3: no-symbols-control-file usr/lib/libtrace.so.3.0.22
I: libwandio1: no-symbols-control-file usr/lib/libwandio.so.1.0.1
I: libtrace3 source: out-of-date-standards-version 3.9.6 (released 2014-09-17) (current is 4.6.2)
I: libtrace-tools: typo-in-manual-page Seperated Separated [usr/share/man/man1/tracertstats.1.gz:69]

If these could be reported as a bug to Debian and perhaps updated packaging provided, that would be ideal. But for now, this looks good to me.

review: Approve

« Back to merge proposal