Code review comment for lp:~submarine/ubuntu-scopes/firefoxbookmarks-multiple-profiles
Revision history for this message
| James Henstridge (jamesh) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Is there any reason you've removed your name from the copyright header?
And while you haven't introduced it in this change, the bare except is bad practice since it can hide mistakes (e.g. if you mistyped a method name, it would swallow the AttributeError). It looks like it would be sufficient to catch sqlite3.