Code review comment for lp:~stylesen/linaro-python-dashboard-bundle/evolve-bundle-stream-1.6

Hi Zyga,

On Tuesday 26 February 2013 04:14 PM, Zygmunt Krynicki wrote:
> Review: Disapprove
>
> 17 + testdef_metadata = {
> 18 + "version": "5",
> 19 + "description": "sample test definition",
> 20 + "format": "Lava Test Shell Format 1.0",
> 21 + "location": "LOCAL",
> 22 + "url": "http://localhost/",
> 23 + "environment": "lava-test-shell",
> 24 + "os": "ubuntu",
> 25 + "devices": "panda"
> 26 + }
>
> Why are you adding that to _all_ documents that previously had no metadata? Do you assume that everything is running ubuntu on a panda board?

My understanding of the above code is when we want to evolve from 1.5 to
1.6 we need to add the above to 1.5 format which will fetch us 1.6
format. This was required by one of the test cases in the test suite for
linaro-python-dashboard-bundle, hence I added it.

Let me know the correct way of doing it.

Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
http://www.sasenthilkumaran.com/