Code review comment for lp:~stylesen/lava-scheduler/fix-worker-multinode-error

Revision history for this message
Antonio Terceiro (terceiro) wrote :

> === modified file 'lava_scheduler_daemon/dbjobsource.py'
> --- lava_scheduler_daemon/dbjobsource.py 2013-08-28 15:13:07 +0000
> +++ lava_scheduler_daemon/dbjobsource.py 2013-08-30 18:09:51 +0000
> @@ -192,7 +192,6 @@
> if d.hostname in configured_boards:
> if job:
> job = self._fix_device(d, job)
> - if job:
> job_list.add(job)

This conditional has to stay because _fix_device (which should be called
_allocate_device instead BTW) might return None, in the case where multiple
schedulers try to allocate the same job to different boards, but the local
scheduler lost the race.

Otherwise +1

 review needs-fixing

review: Needs Fixing

« Back to merge proposal