Merge lp:~stylesen/lava-scheduler/fix-bug-1224261 into lp:lava-scheduler

Proposed by Senthil Kumaran S
Status: Merged
Approved by: Neil Williams
Approved revision: 263
Merged at revision: 265
Proposed branch: lp:~stylesen/lava-scheduler/fix-bug-1224261
Merge into: lp:lava-scheduler
Diff against target: 43 lines (+5/-3)
2 files modified
lava_scheduler_app/models.py (+1/-1)
lava_scheduler_app/views.py (+4/-2)
To merge this branch: bzr merge lp:~stylesen/lava-scheduler/fix-bug-1224261
Reviewer Review Type Date Requested Status
Neil Williams Approve
Review via email: mp+185207@code.launchpad.net

Description of the change

Fix bug #1224261 - submitting a multinode job for a device_type with no boards fails.

To post a comment you must log in.
Revision history for this message
Neil Williams (codehelp) wrote :

Tested on playground, approved. Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lava_scheduler_app/models.py'
--- lava_scheduler_app/models.py 2013-09-04 14:46:59 +0000
+++ lava_scheduler_app/models.py 2013-09-12 06:35:06 +0000
@@ -81,7 +81,7 @@
81 continue81 continue
82 else:82 else:
83 raise DevicesUnavailableException(83 raise DevicesUnavailableException(
84 "Requested %d %s device(s) - only %d available." % (count, board, all_devices[board]))84 "Requested %d %s device(s) - only %d available." % (count, board, all_devices.get(board,0)))
85 return True85 return True
8686
8787
8888
=== modified file 'lava_scheduler_app/views.py'
--- lava_scheduler_app/views.py 2013-09-02 15:14:15 +0000
+++ lava_scheduler_app/views.py 2013-09-12 06:35:06 +0000
@@ -53,6 +53,7 @@
53 TestJob,53 TestJob,
54 JSONDataError,54 JSONDataError,
55 validate_job_json,55 validate_job_json,
56 DevicesUnavailableException,
56)57)
5758
5859
@@ -606,7 +607,8 @@
606 "lava_scheduler_app/job_submit.html",607 "lava_scheduler_app/job_submit.html",
607 response_data, RequestContext(request))608 response_data, RequestContext(request))
608609
609 except (JSONDataError, ValueError) as e:610 except (JSONDataError, ValueError, DevicesUnavailableException) \
611 as e:
610 response_data["error"] = str(e)612 response_data["error"] = str(e)
611 response_data["json_input"] = request.POST.get("json-input")613 response_data["json_input"] = request.POST.get("json-input")
612 return render_to_response(614 return render_to_response(
@@ -842,7 +844,7 @@
842 response_data, RequestContext(request))844 response_data, RequestContext(request))
843 else:845 else:
844 return redirect(job)846 return redirect(job)
845 except Exception as e:847 except (JSONDataError, ValueError, DevicesUnavailableException) as e:
846 response_data["error"] = str(e)848 response_data["error"] = str(e)
847 response_data["json_input"] = definition849 response_data["json_input"] = definition
848 return render_to_response(850 return render_to_response(

Subscribers

People subscribed via source and target branches