Code review comment for lp:~stylesen/lava-dispatcher/add-on-to-testdef-yaml

Senthil Kumaran S <email address hidden> writes:

> === modified file 'lava_dispatcher/test_data.py'
> --- lava_dispatcher/test_data.py 2012-07-31 20:20:02 +0000
> +++ lava_dispatcher/test_data.py 2013-01-28 08:54:19 +0000
> @@ -34,7 +34,8 @@
> def __init__(self, test_id='lava'):
> self.job_status = 'pass'
> self.metadata = {}
> - self._test_run = { 'test_results':[], 'attachments':[], 'tags':[] }
> + self._test_run = { 'test_results':[], 'attachments':[], 'tags':[],
> + 'testdef_metadata':{} }

Does this actually work? The 1.5 bundle format:

http://bazaar.launchpad.net/~linaro-validation/linaro-python-dashboard-bundle/trunk/view/head:/linaro_dashboard_bundle/schemas/dashboard_bundle_format_1.5.json

doesn't allow a testdef_metadata property on elements of the test_run
array.

> self._test_run['test_id'] = test_id
> self._assign_date()
> self._assign_uuid()
> @@ -75,4 +76,3 @@
> def get_test_run(self):
> self.add_result('job_complete', self.job_status)
> return self._test_run
> -
>