Code review comment for lp:~stylesen/lava-dashboard/support-test-definitions

Revision history for this message
Senthil Kumaran S (stylesen) wrote :

Hi Antonio,

On Wed, 2013-04-03 at 23:43 +0000, Antonio Terceiro wrote:
> > === modified file 'dashboard_app/xmlrpc.py'
> > --- dashboard_app/xmlrpc.py 2013-01-15 00:30:25 +0000
> > +++ dashboard_app/xmlrpc.py 2013-04-01 10:18:24 +0000
> > @@ -43,6 +43,7 @@
> > DataView,
> > Test,
> > TestRunFilter,
> > + TestDefinition,
> > )
> >
> >
> > @@ -436,7 +437,7 @@
> > """
> > test_names = []
> > if device_type:
> > - for test in Test.objects.filter(
> > + for test in Testobjects.filter(
>
> typo

Thanks for catching it. This is unrelated to my change, but I hope I did
some formatting tweaks which touched this line and by mistake I made
that typo. Anyways, I corrected it in r414.

Thank You.

--
Senthil Kumaran
http://www.stylesen.org/
http://www.sasenthilkumaran.com/

« Back to merge proposal