Code review comment for lp:~stub/python-pgbouncer/devel

On Tue, Sep 13, 2011 at 7:28 AM, Robert Collins
<email address hidden> wrote:
> Less abruptly, I've mailed the -dev list the (hard) lesson learnt
> there. And to avoid creating extra work for you, I've rolled this
> back, proposed a narrower fix, got that reviewed, released and its now
> playing in EC2 to upgrade LP to 0.0.5.

So this version is missing the '\n' detection to ensure the pid number
has actually been flushed as expected, and also doesn't help with the
race condition where starting up enough to write the pid file doesn't
mean the process is bound and accepting connections. I think what I
had except for my final commit would have been better, or using
os.devnull if we don't trust -q.

--
Stuart Bishop <email address hidden>
http://www.stuartbishop.net/