Code review comment for lp:~stub/python-pgbouncer/devel

On Sat, Sep 10, 2011 at 9:49 PM, Jeroen T. Vermeulen <email address hidden> wrote:
> Review: Approve
>
> Much better approach I think, thanks.
>
> There's a small wart still, as far as I can see: a timeout seems likely to manifest itself in the form of a nonpositive timeout value being passed to the connection call.

I don't see how a nonpositive timeout can be passed to the connection
call unless someone sets the constance to <= 0. The loop is exited
with a 'raise' if we grab a new value of 'now' and find the timeout
has been hit.

--
Stuart Bishop <email address hidden>
http://www.stuartbishop.net/