Merge lp:~stub/launchpad/trivial into lp:launchpad

Proposed by Stuart Bishop
Status: Merged
Approved by: Данило Шеган
Approved revision: 9976
Merged at revision: 13600
Proposed branch: lp:~stub/launchpad/trivial
Merge into: lp:launchpad
To merge this branch: bzr merge lp:~stub/launchpad/trivial
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
Review via email: mp+70284@code.launchpad.net

Commit message

[r=danilo][bug=820291] Work around Bug #820290 in BugHeatUpdater

Description of the change

= Summary =

BugHeatUpdater needs to work around Storm Bug #820290

== Proposed fix ==

Work around it, and fix the tests which were wrong and hiding this problem. Also remove the 'multiply chunksize by 1000' hack, which is incorrect (LoopTuner does this, and if you want a minimum batch size you set that property)

== Tests ==

./test.py -vv bug-heat.txt

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

Looks good, I "like" it how loop was called with chunk_size of 1 and processed two entries in the test. :)

As a side-note, is it perhaps worth changing the query to be a "update where id in (outdated_bug_ids)" with only outdated bug ids listified?

review: Approve
lp:~stub/launchpad/trivial updated
9977. By Stuart Bishop

Improvements from review

Revision history for this message
Stuart Bishop (stub) wrote :

I rewrote the update query per suggestions.