Code review comment for lp:~stub/launchpad/garbo

On Wed, Apr 8, 2009 at 4:42 AM, Stuart Bishop <email address hidden> wrote:

> I thought I'd fixed the logic to stop that already. I have a
> consistent 'now' at the top of the test. The first test checks that
> there is at least one item expired at time 'now'. The second check
> tests that there are 0 items expired at time 'now'.  The only change I
> see if things pause or run slow is self.runHourly(), and this just
> means more items might get expired. The final check doesn't care,
> because it is just ensuring that all the items at the test start time
> where expired and it couldn't care less if more where expired.
>
> So if my logic is correct (it is 4:30am), the problem is that I'm not
> checking that items that should not have been expired have not been
> expired.

I've commented this test better and added the extra 'make sure we didn't just trash everything' check.

--
Stuart Bishop <email address hidden>
http://www.stuartbishop.net/