Code review comment for lp:~stub/launchpad/branch-rewrite

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Thanks for taking the trouble.

A tip for nonblocking_readline: the time calculations get simpler if you introduce a variable “deadline”:

 * deadline = start + timeout
 * “now < start - timeout” becomes “now < deadline”
 * “timeout - (now - start)” becomes “deadline - now”

(Both in their way involve computing the time remaining, but I'm not sure that making that explicit as well makes things any better.)

Jeroen

review: Approve

« Back to merge proposal