Merge lp:~stub/charms/precise/postgresql/syslog into lp:charms/postgresql
Proposed by
Stuart Bishop
Status: | Merged |
---|---|
Merged at revision: | 88 |
Proposed branch: | lp:~stub/charms/precise/postgresql/syslog |
Merge into: | lp:charms/postgresql |
Prerequisite: | lp:~stub/charms/precise/postgresql/bug-1278731-hot-standby-allowed-units |
Diff against target: |
271 lines (+147/-1) 7 files modified
README.md (+10/-0) config.yaml (+1/-1) hooks/hooks.py (+73/-0) metadata.yaml (+2/-0) templates/postgresql.conf.tmpl (+2/-0) templates/rsyslog_forward.conf (+19/-0) test.py (+40/-0) |
To merge this branch: | bzr merge lp:~stub/charms/precise/postgresql/syslog |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marco Ceppi (community) | Approve | ||
Charles Butler (community) | deployment + audit | Approve | |
Review via email: mp+206176@code.launchpad.net |
Description of the change
Ship PostgreSQL log files via syslog.
I'm not too familiar with other charms using syslog, in particular if I should be sending on port 10514 or 514, so I'd like a review from someone who has done work in this area.
The goal of this work is to connect PostgreSQL to reporting programs, and I'll be creating a pgBadger charm shortly that will consume the logs. For this use case, I also need to advertise the log_line_prefix that PostgreSQL uses to consumers, so they can decode the logs. I also added the programname required to tell logs from different units apart (IP address isn't reliable).
To post a comment you must log in.
Stuart,
These modifications look fine to me. I've pulled them and deployed, setup a rather basic deployment test using rsyslog charm and the branch+prereq on HP-Cloud, AWS, and Local providers. All of which were properly forwarding the syslog. I haven't deployed the PGBadger service, however I see it as being ready in the queue, and I'll get to that next with additional commentary.
From what I've experienced in the past, forwarding over port 514 to your logging-nexus is perfectly acceptable. If you want to get into TLS wrapping your rsyslog forwarding, that's typically when you go to port 1999, so I'm a bit confused on the port 10514 dialogue above. Can you shed some light on why that was of a concern?
I'll be pushing this review to another charmer for an additional +1 review.
Thank you for the submission, keep up the excellent work!