Merge lp:~stub/charm-helpers/shush-apt into lp:charm-helpers

[Stuart Bishop]

charmhelpers.fetch.apt_cache() spams logs. Stop it by default.

[James Page (james-page)]

+1 much needed.

review: Approve

=== modified file 'charmhelpers/fetch/__init__.py'
--- charmhelpers/fetch/__init__.py	2016-07-06 14:41:05 +0000
+++ charmhelpers/fetch/__init__.py	2016-07-14 10:24:37 +0000
@@ -178,14 +178,14 @@
     return _pkgs
 
 
-def apt_cache(in_memory=True):
+def apt_cache(in_memory=True, progress=None):
     """Build and return an apt cache"""
     from apt import apt_pkg
     apt_pkg.init()
     if in_memory:
         apt_pkg.config.set("Dir::Cache::pkgcache", "")
         apt_pkg.config.set("Dir::Cache::srcpkgcache", "")
-    return apt_pkg.Cache()
+    return apt_pkg.Cache(progress)
 
 
 def apt_install(packages, options=None, fatal=False):
 
=== modified file 'tests/fetch/test_fetch.py'
--- tests/fetch/test_fetch.py	2015-12-09 23:06:09 +0000
+++ tests/fetch/test_fetch.py	2016-07-14 10:24:37 +0000
@@ -31,7 +31,7 @@
 }
 
 
-def fake_apt_cache():
+def fake_apt_cache(in_memory=True, progress=None):
     def _get(package):
         pkg = MagicMock()
         if package not in FAKE_APT_CACHE: