Merge lp:~stub/charm-helpers/py3 into lp:charm-helpers
Proposed by
Stuart Bishop
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 371 | ||||||||
Proposed branch: | lp:~stub/charm-helpers/py3 | ||||||||
Merge into: | lp:charm-helpers | ||||||||
Diff against target: |
213 lines (+68/-18) 7 files modified
charmhelpers/contrib/peerstorage/__init__.py (+2/-0) charmhelpers/core/hookenv.py (+6/-0) charmhelpers/core/host.py (+1/-1) charmhelpers/fetch/__init__.py (+1/-1) tests/contrib/peerstorage/test_peerstorage.py (+8/-0) tests/core/test_hookenv.py (+37/-1) tests/core/test_templating.py (+13/-15) |
||||||||
To merge this branch: | bzr merge lp:~stub/charm-helpers/py3 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jorge Niedbalski (community) | Needs Fixing | ||
charmers | Pending | ||
Review via email: mp+244668@code.launchpad.net |
Description of the change
A small grabbag of fixes I have needed putting together a new charm.
The main fix is host.write() for Python3, where Python3 is picky about byte strings vs. text strings. Since we use write for all sorts of files, it needs to accept byte strings. Py2 users are unaffected.
Includes fixes for Bug #1402192 , as well as https:/
To post a comment you must log in.
LGTM, minor observations.