Charm Helpers

Code review comment for lp:~stub/charm-helpers/py3-2

  1. py3-2
  2. Merge into devel
Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

> Running make test in a clean precise lxc:
>
> Checking for Python syntax...
> Py2 OK
> charmhelpers/contrib/templating/contexts.py:99:54: E901 SyntaxError: invalid
> syntax
> tests/contrib/templating/test_contexts.py:137:31: E901 SyntaxError: invalid
> syntax
> tests/core/test_hookenv.py:132:40: E901 SyntaxError: invalid syntax
> make: *** [lint] Error 1
>
>
> Also, running apt-get as an import side-effect makes me grimace.

Retested on precise and tests pass. Sorry for the noise, not sure what happened the first time.

« Back to merge proposal