Code review comment for lp:~stub/charm-helpers/py3-2

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

My preliminary review shows everything OK.

- Trusty tests OK [python2.7, python3.4]
   - No import errors

- Precise tests OK [python2.7, python3.2]
   - No import errors

---------------------------------------------------------------------------
TOTAL 3683 236 94%
----------------------------------------------------------------------
Ran 773 tests in 7.484s

OK (SKIP=7)
OK

ubuntu@precise:~/charm-helpers$ sudo python2.7
Python 2.7.3 (default, Feb 27 2014, 19:58:35)
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import charmhelpers
>>>

Python 3.2.3 (default, Feb 27 2014, 21:31:18)
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import charmhelpers
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
  python3-six
0 upgraded, 1 newly installed, 0 to remove and 54 not upgraded.
Need to get 5,894 B of archives.
After this operation, 50.2 kB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu/ precise/universe python3-six all 1.1.0-2 [5,894 B]
Fetched 5,894 B in 0s (16.7 kB/s)
Selecting previously unselected package python3-six.
(Reading database ... 58662 files and directories currently installed.)
Unpacking python3-six (from .../python3-six_1.1.0-2_all.deb) ...
Setting up python3-six (1.1.0-2) ...
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
  python3-yaml
0 upgraded, 1 newly installed, 0 to remove and 54 not upgraded.
Need to get 111 kB of archives.
After this operation, 442 kB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu/ precise/main python3-yaml amd64 3.10-2 [111 kB]
Fetched 111 kB in 0s (120 kB/s)
Selecting previously unselected package python3-yaml.
(Reading database ... 58667 files and directories currently installed.)
Unpacking python3-yaml (from .../python3-yaml_3.10-2_amd64.deb) ...
Setting up python3-yaml (3.10-2) ...
>>>

« Back to merge proposal