Code review comment for lp:~stub/charm-helpers/bug-1195649-fix-write-file

Revision history for this message
Matthew Wedgwood (mew) wrote :

Stuart,

Thanks for cleaning this up. I agree that template rendering should be a separate concern from writing a file. I'm +1 on this change with one caveat:

As py_render() isn't host-related (nor is the existing render_template_file() function), it should live somewhere outside this module. charmhelpers.contrib.template might be appropriate, as most any other template renderers will have external dependencies.

-Matthew

review: Needs Fixing

« Back to merge proposal