Code review comment for lp:~stothardj/dracula/nonodelist
Revision history for this message
| Jake Stothard (stothardj) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Short answer: No, you can pull it out.
I thought I'd be using jQuery for more in this, but it seems not to be
necessary actually. I was using jQuery.extend to make copies, but I saw you
had a clone function so if that works that can be used. The other thing was
using jQuery to get the window size in the demos, which again is replacable.
That's all I can see that I used.
On Wed, Nov 3, 2010 at 2:34 AM, Filip <email address hidden> wrote:
> Yes, I have a first question after a first glance at the diff: Is the
> jQuery dependency really necessary? I like jQuery and use it for most of my
> projects anyway, but otherwise I wanted to keep the dependencies as minimal
> as possible. Like for example, there used to be a Prototype dependency just
> for using class structures, until I figured out that using plain JavaScript
> prototype and such would do the same with the same amount of code.
>
> So, if you really think jQuery is a big help here and it's not possible
> without it, I will leave the jQuery code in Dracula.
> --
> https:/
> You are the owner of lp:~stothardj/dracula/nonodelist.
>