Unity 8

Code review comment for lp:~stolowski/unity8/results-nullptr-fix

  1. results-nullptr-fix
  2. Merge into trunk
Revision history for this message
Michal Hruby (mhr3) wrote :

17 + if (unity_results) {
18 + results->setModel(unity_results->model());
19 + } else {

The else branch should call setModel(NULL), although I'm not sure what to do about the cached value in that case.

49 + m_resultshangedConnection.disconnect();
50 + m_resultshangedConnection = m_unityScope->results()->model.changed.connect(sigc::mem_fun(this, &Categories::onScopeResultsModelChanged));

I specifically didn't want that signal, cause now we end up setting the model multiple times.

« Back to merge proposal