Code review comment for lp:~stolowski/unity-scopes-shell/prepopulate-scopes-when-locked

Revision history for this message
Paweł Stołowski (stolowski) wrote :

> Looks good. Just a question: What was the motivation behind the
> UNITY_SCOPES_NO_PREPOPULATE_FIRST variable?

Solely to leave backdoor for disabling this enhancement in tests. All tests which fully utilize scope-harness (such as resultstest) work fine, but all the filters tests (which haven't been migrated to scope harness) which rely TestUtils::performSearch broke because the scope is not in the expected state when tests starts (search is already in progress due to pre-population logic, and TestUtils::performSearch doesn't expect that). After some failed attempts to work around this in the tests I concluded it's probably now worth the effort.

« Back to merge proposal