Code review comment for lp:~stolowski/unity-scopes-shell/location-changes

Revision history for this message
Paweł Stołowski (stolowski) wrote :

> Looks good, although one observation:
>
> I have Nearby favourited. Once I have enabled location access to scopes and I
> restart the phone, the scope says "Please enable location..." again. I also
> notice incorrect weather shown on the Today scope. There's obviously a race in
> scopes startup and the location becoming available/accessible/enabled. Not
> sure how easy this would be to fix, but it is a bit confusing.

Right. I've missed that during my refactoring. The implementation should handle this now, however for some reason I'm always getting error (access denied) from Qt location API on the initial request when Dash is starting. I asked Thomas to check the backend.

>
> + For some reason I can't edit the test plan page anymore, so I'll just add
> review comments for that here:
>
> 1) "for testing purposes, remove
> home/phablet/.local/share/UbuntuLocationService/trust.db"
>
> missing a / before "home"
>
> 2) Select 'Deny'.
>
> should say "Select 'Don't Allow'."

Ok, the test plan has been fixed.

« Back to merge proposal