Merge lp:~stolowski/unity-scope-mediascanner/video-sharing into lp:unity-scope-mediascanner

Proposed by Paweł Stołowski
Status: Merged
Approved by: James Henstridge
Approved revision: 322
Merged at revision: 320
Proposed branch: lp:~stolowski/unity-scope-mediascanner/video-sharing
Merge into: lp:unity-scope-mediascanner
Diff against target: 15 lines (+5/-0)
1 file modified
src/myvideos/video-scope.cpp (+5/-0)
To merge this branch: bzr merge lp:~stolowski/unity-scope-mediascanner/video-sharing
Reviewer Review Type Date Requested Status
James Henstridge Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+297789@code.launchpad.net

Commit message

Enable sharing via preview for local videos.

Description of the change

Enable sharing via preview for local videos.

To post a comment you must log in.
Revision history for this message
James Henstridge (jamesh) wrote :

It looks like the code in this branch might have some file name / URI confusion, which could cause problems for file names that contain reserved characters.

review: Needs Information
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/myvideos/video-scope.cpp'
--- src/myvideos/video-scope.cpp 2016-01-13 05:23:56 +0000
+++ src/myvideos/video-scope.cpp 2016-06-20 08:21:09 +0000
@@ -322,6 +322,11 @@
322 video.add_attribute_value("source", Variant(uri));322 video.add_attribute_value("source", Variant(uri));
323 video.add_attribute_mapping("screenshot", "art");323 video.add_attribute_mapping("screenshot", "art");
324324
325 VariantMap share_data;
326 share_data["uri"] = Variant(result().uri());
327 share_data["content-type"] = Variant("videos");
328 video.add_attribute_value("share-data", Variant(share_data));
329
325 PreviewWidget actions("actions", "actions");330 PreviewWidget actions("actions", "actions");
326 {331 {
327 VariantBuilder builder;332 VariantBuilder builder;

Subscribers

People subscribed via source and target branches

to all changes: