9 + internal async void handle_metrics (uint action_type, string scope_id, string session_id, string server_sid) 10 { 11 + if (server_sid == null) 12 + return;
You don't allow server_sid to be null ("string server_sid", no "string? server_sid"), so the check is useless.
55 + (activation.action_type == Unity.Protocol.ActionType.ACTIVATE_RESULT || 56 + activation.action_type == Unity.Protocol.ActionType.PREVIEW_RESULT))
Shouldn't this check if the scope is really remote? Or is that check done earlier?
« Back to merge proposal
9 + internal async void handle_metrics (uint action_type, string scope_id, string session_id, string server_sid)
10 {
11 + if (server_sid == null)
12 + return;
You don't allow server_sid to be null ("string server_sid", no "string? server_sid"), so the check is useless.
55 + (activation. action_ type == Unity.Protocol. ActionType. ACTIVATE_ RESULT || action_ type == Unity.Protocol. ActionType. PREVIEW_ RESULT) )
56 + activation.
Shouldn't this check if the scope is really remote? Or is that check done earlier?