Code review comment for lp:~stolowski/unity-scope-home/cancellables

Revision history for this message
Michal Hruby (mhr3) wrote :

57 + }, cancellable, sss_cb);

I'm a bit worried that there are no extra cancellable checks inside the SSSClient implementation, isn't it possible that it's cancelled after the query finishes but before the json parsing is done? In that case the callbacks will still be called and could cause a crash.

108 + debug ("The search for channel %s was cancelled", scope_search.channel_id);

Will be more useful if you also log the current search_query.

« Back to merge proposal