Code review comment for lp:~stolowski/unity-scope-click/use-local-departments

Revision history for this message
Alejandro J. Cura (alecu) wrote :

Branch looks mostly fine. One small comment, that we can fix in a following branch:

The big test function in:
TEST(Query, Departments)

Does not follow the naming convention for tests, and should perhaps be split into two test functions sharing a common class, like:

TEST_F(DepartmentsTest, testRootDepartment)
TEST_F(DepartmentsTest, testLeafDepartment)

review: Approve

« Back to merge proposal