Code review comment for lp:~stolowski/unity-scope-click/network-cache
Revision history for this message
| Alejandro J. Cura (alecu) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
On Mon, Aug 11, 2014 at 7:34 PM, Michał Sawicz
<email address hidden> wrote:
> Would it make sense to check for network and do AlwaysCache when offline? Otherwise this will try and call up to the server anyway?
Good point, we should definitely investigate the behavior when
offline, and also we should check if the cached entries are skipped if
the language is changed.
I don't think though that those points are blockers for landing this branch.