Merge lp:~stolowski/unity-scope-click/header-apps into lp:unity-scope-click/devel

[Paweł Stołowski]

Display preloaded core apps at the top in a dedicated headerless category. The list of apps to be displayed can be overriden with a dconf key.

Display preloaded core apps at the top in a dedicated headerless category. The list of apps to be displayed can be overriden with a dconf key.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:319
http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-ci/166/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-amd64-ci/141/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-armhf-ci/140/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-i386-ci/140/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-team-unity-scope-click-devel-ci/166/rebuild

review: Needs Fixing (continuous-integration)

[Alejandro J. Cura (alecu)]

Code looks good; seems to be missing libgsettings-qt-dev in debian/control
Will test it on device after jenkins approves.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:320
http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-ci/169/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-amd64-ci/144
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-armhf-ci/143
        deb: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-armhf-ci/143/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-i386-ci/143

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-team-unity-scope-click-devel-ci/169/rebuild

review: Approve (continuous-integration)

[Alejandro J. Cura (alecu)]

Tested on mako, looks wonderful.

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-autolanding/70/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-amd64-autolanding/55/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-armhf-autolanding/55/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-team-unity-scope-click-devel-utopic-i386-autolanding/55/console

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2014-06-23 15:00:28 +0000
+++ CMakeLists.txt	2014-07-08 07:23:41 +0000
@@ -20,6 +20,7 @@
 set(APPS_DATA_DIR ${CMAKE_INSTALL_FULL_DATADIR}/unity/scopes/clickapps/)
 
 include(FindPkgConfig)
+include(UseGSettings)
 
 pkg_check_modules(UNITY_SCOPES REQUIRED libunity-scopes>=0.5.0 libunity-api>=0.1.3)
 add_definitions(${UNITY_SCOPES_CFLAGS} ${UNITY_SCOPES_CFLAGS_OTHER})
@@ -75,7 +76,7 @@
 
 # Custom targets for the tests
 add_custom_target (test
-  DEPENDS test-click-scope test-libclickscope
+  DEPENDS test-click-scope test-apps-scope test-libclickscope
 )
 
 add_custom_target (test-disabled
@@ -90,13 +91,13 @@
 
 # Add a custom target for running the tests under valgrind.
 add_custom_target (test-valgrind
-  DEPENDS test-click-scope-valgrind test-libclickscope-valgrind
+  DEPENDS test-click-scope-valgrind test-apps-scope-valgrind test-libclickscope-valgrind
 )
 
 # Add a custom target for running the tests under valgrind with the
 # full leak checks enabled.
 add_custom_target (test-leaks
-  DEPENDS test-click-scope-leaks test-libclickscope-leaks
+  DEPENDS test-click-scope-leaks test-apps-scope-leaks test-libclickscope-leaks
 )
 
 # Also let "make check" and partners work.
 
=== added file 'cmake/UseGSettings.cmake'
--- cmake/UseGSettings.cmake	1970-01-01 00:00:00 +0000
+++ cmake/UseGSettings.cmake	2014-07-08 07:23:41 +0000
@@ -0,0 +1,42 @@
+# GSettings.cmake, CMake macros written for Marlin, feel free to re-use them.
+
+option (GSETTINGS_LOCALINSTALL "Install GSettings Schemas locally instead of to the GLib prefix" ${LOCAL_INSTALL})
+
+option (GSETTINGS_COMPILE "Compile GSettings Schemas after installation" ${GSETTINGS_LOCALINSTALL})
+
+if(GSETTINGS_LOCALINSTALL)
+    message(STATUS "GSettings schemas will be installed locally.")
+endif()
+
+if(GSETTINGS_COMPILE)
+    message(STATUS "GSettings shemas will be compiled.")
+endif()
+
+macro(add_schema SCHEMA_NAME)
+
+    set(PKG_CONFIG_EXECUTABLE pkg-config)
+    # Have an option to not install the schema into where GLib is
+    if (GSETTINGS_LOCALINSTALL)
+        SET (GSETTINGS_DIR "${CMAKE_INSTALL_PREFIX}/share/glib-2.0/schemas/")
+    else (GSETTINGS_LOCALINSTALL)
+        execute_process (COMMAND ${PKG_CONFIG_EXECUTABLE} glib-2.0 --variable prefix OUTPUT_VARIABLE _glib_prefix OUTPUT_STRIP_TRAILING_WHITESPACE)
+        SET (GSETTINGS_DIR "${_glib_prefix}/share/glib-2.0/schemas/")
+    endif (GSETTINGS_LOCALINSTALL)
+
+    # Run the validator and error if it fails
+    execute_process (COMMAND ${PKG_CONFIG_EXECUTABLE} gio-2.0 --variable glib_compile_schemas  OUTPUT_VARIABLE _glib_comple_schemas OUTPUT_STRIP_TRAILING_WHITESPACE)
+    execute_process (COMMAND ${_glib_comple_schemas} --dry-run --schema-file=${CMAKE_CURRENT_SOURCE_DIR}/${SCHEMA_NAME} ERROR_VARIABLE _schemas_invalid OUTPUT_STRIP_TRAILING_WHITESPACE)
+
+    if (_schemas_invalid)
+      message (SEND_ERROR "Schema validation error: ${_schemas_invalid}")
+    endif (_schemas_invalid)
+
+    # Actually install and recomple schemas
+    message (STATUS "GSettings schemas will be installed into ${GSETTINGS_DIR}")
+    install (FILES ${CMAKE_CURRENT_SOURCE_DIR}/${SCHEMA_NAME} DESTINATION ${GSETTINGS_DIR} OPTIONAL)
+
+    if (GSETTINGS_COMPILE)
+        install (CODE "message (STATUS \"Compiling GSettings schemas\")")
+        install (CODE "execute_process (COMMAND ${_glib_comple_schemas} ${GSETTINGS_DIR})")
+    endif ()
+endmacro()
 
=== modified file 'data/CMakeLists.txt'
--- data/CMakeLists.txt	2014-06-30 21:50:00 +0000
+++ data/CMakeLists.txt	2014-07-08 07:23:41 +0000
@@ -2,6 +2,8 @@
 set(STORE_INI_TARGET com.canonical.scopes.clickstore.ini)
 set(APPS_INI_TARGET clickscope.ini)
 
+add_schema(com.canonical.unity.clickscope.gschema.xml)
+
 configure_file(
   ${STORE_INI_TARGET}.in.in
   ${STORE_INI_TARGET}.in
 
=== added file 'data/com.canonical.unity.clickscope.gschema.xml'
--- data/com.canonical.unity.clickscope.gschema.xml	1970-01-01 00:00:00 +0000
+++ data/com.canonical.unity.clickscope.gschema.xml	2014-07-08 07:23:41 +0000
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<schemalist>
+  <schema path="/com/canonical/unity/clickscope/" id="com.canonical.Unity.ClickScope" gettext-domain="unity-scope-click">
+    <key type="as" name="core-apps">
+      <default>[]</default>
+      <summary>Applications to display in the top category of the Apps scope</summary>
+      <description>List of application IDs that will be displayed in the upper area of the Applications scope for quick access.</description>
+    </key>
+  </schema>
+</schemalist>
 
=== modified file 'debian/control'
--- debian/control	2014-06-23 15:00:28 +0000
+++ debian/control	2014-07-08 07:23:41 +0000
@@ -14,6 +14,7 @@
                libubuntuoneauth-2.0-dev,
                libunity-api-dev (>= 7.80.7),
                libunity-scopes-dev (>= 0.5.0),
+               libgsettings-qt-dev,
                pkg-config,
                python3-all,
 Maintainer: Ubuntu Developers <[e-mail]>
 
=== modified file 'debian/unity-scope-click.install'
--- debian/unity-scope-click.install	2014-06-20 20:00:53 +0000
+++ debian/unity-scope-click.install	2014-07-08 07:23:41 +0000
@@ -1,4 +1,5 @@
 usr/lib/*/unity-scopes/*
 usr/lib/unity-scope-click/*
 usr/share/unity/scopes/*
+usr/share/glib-2.0/schemas/*
 usr/share/locale/*/LC_MESSAGES/unity-scope-click.mo
 
=== modified file 'libclickscope/click/CMakeLists.txt'
--- libclickscope/click/CMakeLists.txt	2014-06-23 15:00:28 +0000
+++ libclickscope/click/CMakeLists.txt	2014-07-08 07:23:41 +0000
@@ -2,11 +2,13 @@
 SET (CMAKE_AUTOMOC ON)
 find_package (Qt5Core REQUIRED)
 pkg_check_modules(JSON_CPP REQUIRED jsoncpp)
+pkg_check_modules(GSETTINGS_QT REQUIRED gsettings-qt)
 
 add_definitions(
   -DGETTEXT_PACKAGE=\"${PROJECT_NAME}\"
   -DGETTEXT_LOCALEDIR=\"${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LOCALEDIR}\"
   -DCLICK_INSTALL_HELPER=\"${CMAKE_INSTALL_PREFIX}/lib/unity-scope-click/install-helper\"
+  ${GSETTINGS_QT_CFLAGS} ${GSETTINGS_QT_OTHER}
 )
 
 add_library(${SCOPE_LIB_NAME} STATIC
@@ -32,6 +34,7 @@
 
 include_directories(
   ${JSON_CPP_INCLUDE_DIRS}
+  ${GSETTINGS_QT_INCLUDE_DIRS}
   ${CMAKE_SOURCE_DIR}/libclickscope
 )
 
@@ -41,5 +44,6 @@
   ${UBUNTUONE_LDFLAGS}
   ${UBUNTU_DOWNLOAD_MANAGER_CLIENT_LDFLAGS}
   ${UBUNTU_DOWNLOAD_MANAGER_COMMON_LDFLAGS}
+  ${GSETTINGS_QT_LIBRARIES}
   -lboost_locale
 )
 
=== modified file 'libclickscope/click/configuration.cpp'
--- libclickscope/click/configuration.cpp	2014-06-25 21:33:59 +0000
+++ libclickscope/click/configuration.cpp	2014-07-08 07:23:41 +0000
@@ -32,6 +32,11 @@
 
 #include <QDir>
 #include <QProcess>
+#include <QStringList>
+#include <QVariant>
+#include <QDebug>
+
+#include <qgsettings.h>
 
 #include <boost/algorithm/string.hpp>
 #include <boost/algorithm/string/replace.hpp>
@@ -141,4 +146,36 @@
         != FULL_LANG_CODES.end();
 }
 
+const std::vector<std::string> Configuration::get_dconf_strings(const std::string& schema, const std::string& key) const
+{
+    if (!QGSettings::isSchemaInstalled(schema.c_str()))
+    {
+        qWarning() << "Schema" << QString::fromStdString(schema) << "is missing";
+        return std::vector<std::string>();
+    }
+    QGSettings qgs(schema.c_str());
+    std::vector<std::string> v;
+    if (qgs.keys().contains(QString::fromStdString(key)))
+    {
+        auto locations = qgs.get(QString::fromStdString(key)).toStringList();
+        for(const auto& l : locations) {
+            v.push_back(l.toStdString());
+        }
+    }
+    else
+    {
+        qWarning() << "No" << QString::fromStdString(key) << " key in schema" << QString::fromStdString(schema);
+    }
+    return v;
+}
+
+const std::vector<std::string> Configuration::get_core_apps() const
+{
+    auto apps = get_dconf_strings(Configuration::COREAPPS_SCHEMA, Configuration::COREAPPS_KEY);
+    if (apps.empty()) {
+        apps = get_default_core_apps();
+    }
+    return apps;
+}
+
 } // namespace click
 
=== modified file 'libclickscope/click/configuration.h'
--- libclickscope/click/configuration.h	2014-06-25 21:33:59 +0000
+++ libclickscope/click/configuration.h	2014-07-08 07:23:41 +0000
@@ -54,10 +54,26 @@
     virtual std::string get_accept_languages();
     static bool is_full_lang_code(const std::string& language);
 
+    constexpr static const char* COREAPPS_SCHEMA {"com.canonical.Unity.ClickScope"};
+    constexpr static const char* COREAPPS_KEY {"coreApps"};
+
+    virtual const std::vector<std::string> get_core_apps() const;
     virtual ~Configuration() {}
 protected:
     virtual std::vector<std::string> list_folder(const std::string &folder, const std::string &pattern);
     virtual std::string architectureFromDpkg();
+    virtual const std::vector<std::string> get_dconf_strings(const std::string& schema, const std::string& key) const;
+    static const std::vector<std::string>& get_default_core_apps() {
+        static std::vector<std::string> default_apps {
+            "dialer-app",
+            "messaging-app",
+            "com.ubuntu.calculator",
+            "com.ubuntu.clock",
+            "com.ubuntu.camera",
+            "com.ubuntu.calendar"
+        };
+        return default_apps;
+    }
 };
 
 } // namespace click
 
=== modified file 'libclickscope/tests/test_configuration.cpp'
--- libclickscope/tests/test_configuration.cpp	2014-06-25 21:33:59 +0000
+++ libclickscope/tests/test_configuration.cpp	2014-07-08 07:23:41 +0000
@@ -27,6 +27,8 @@
  * files in the program, then also delete it here.
  */
 
+#include <QStringList>
+
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 
@@ -42,10 +44,35 @@
 public:
     MOCK_METHOD2(list_folder, std::vector<std::string>(
                      const std::string& folder, const std::string& pattern));
+    MOCK_CONST_METHOD2(get_dconf_strings, const std::vector<std::string>(const std::string& schema, const std::string& key));
+    using Configuration::get_default_core_apps;
 };
 
 }
 
+TEST(Configuration, getCoreAppsFound)
+{
+    using namespace ::testing;
+    FakeConfiguration c;
+    EXPECT_CALL(c, get_dconf_strings(Configuration::COREAPPS_SCHEMA,
+                                     Configuration::COREAPPS_KEY))
+            .WillOnce(Return(std::vector<std::string>{"package1", "package2"}));
+    auto found_apps = c.get_core_apps();
+    auto expected_apps = std::vector<std::string>{"package1", "package2"};
+    ASSERT_EQ(found_apps, expected_apps);
+}
+
+TEST(Configuration, getCoreAppsEmpty)
+{
+    using namespace ::testing;
+    FakeConfiguration c;
+    EXPECT_CALL(c, get_dconf_strings(Configuration::COREAPPS_SCHEMA,
+                                     Configuration::COREAPPS_KEY))
+            .WillOnce(Return(std::vector<std::string>{}));
+    auto found_apps = c.get_core_apps();
+    auto expected_apps = c.get_default_core_apps();
+    ASSERT_EQ(found_apps, expected_apps);
+}
 
 TEST(Configuration, getAvailableFrameworksUsesRightFolder)
 {
 
=== modified file 'scope/clickapps/apps-query.cpp'
--- scope/clickapps/apps-query.cpp	2014-06-30 20:06:33 +0000
+++ scope/clickapps/apps-query.cpp	2014-07-08 07:23:41 +0000
@@ -42,6 +42,7 @@
 
 #include <click/click-i18n.h>
 #include "apps-query.h"
+#include <QDebug>
 
 namespace
 {
@@ -64,24 +65,6 @@
     }
 )";
 
-std::string CATEGORY_APPS_SEARCH = R"(
-    {
-        "schema-version" : 1,
-        "template" : {
-            "category-layout" : "grid",
-            "card-layout" : "horizontal",
-            "card-size": "large"
-        },
-        "components" : {
-            "title" : "title",
-            "mascot" : {
-                "field": "art"
-            },
-            "subtitle": "publisher"
-        }
-    }
-)";
-
 static const char CATEGORY_STORE[] = R"(
 {
   "template": {
@@ -104,51 +87,138 @@
 
 }
 
-void click::Query::push_local_results(scopes::SearchReplyProxy const &replyProxy,
-                                      std::vector<click::Application> const &apps,
-                                      std::string &categoryTemplate)
-{
-    scopes::CategoryRenderer rdr(categoryTemplate);
+click::apps::ResultPusher::ResultPusher(const scopes::SearchReplyProxy &replyProxy, const std::vector<std::string>& core_apps)
+    :  replyProxy(replyProxy),
+       core_apps(core_apps),
+       top_apps_lookup(core_apps.begin(), core_apps.end())
+{
+}
+
+void click::apps::ResultPusher::push_result(scopes::Category::SCPtr& cat, const click::Application& a)
+{
+    scopes::CategorisedResult res(cat);
+    res.set_title(a.title);
+    res.set_art(a.icon_url);
+    res.set_uri(a.url);
+    res[click::apps::Query::ResultKeys::NAME] = a.name;
+    res[click::apps::Query::ResultKeys::DESCRIPTION] = a.description;
+    res[click::apps::Query::ResultKeys::MAIN_SCREENSHOT] = a.main_screenshot;
+    res[click::apps::Query::ResultKeys::INSTALLED] = true;
+    res[click::apps::Query::ResultKeys::VERSION] = a.version;
+    replyProxy->push(res);
+}
+
+//
+// Return an application identifier used to match applications against core-apps dconf key;
+// For click apps, it just returns application name (e.g. com.canonical.calculator).
+// For non-click apps, it return the desktop file name (without extension), taken from app uri.
+std::string click::apps::ResultPusher::get_app_identifier(const click::Application& app)
+{
+    static const std::string app_prefix("application:///");
+    if (!app.name.empty())
+    {
+        return app.name;
+    }
+    if (app.url.size() > app_prefix.size())
+    {
+        auto i = app.url.rfind('.');
+        if (i != std::string::npos)
+        {
+            return app.url.substr(app_prefix.size(), i - app_prefix.size());
+        }
+    }
+    throw std::runtime_error("Cannot determine application identifier for" + app.url);
+}
+
+void click::apps::ResultPusher::push_local_results(
+                                      const std::vector<click::Application> &apps,
+                                      const std::string &categoryTemplate)
+{
+    const scopes::CategoryRenderer rdr(categoryTemplate);
     auto cat = replyProxy->register_category("local", _("My apps"), "", rdr);
 
     for(const auto & a: apps)
     {
-        scopes::CategorisedResult res(cat);
-        res.set_title(a.title);
-        res.set_art(a.icon_url);
-        res.set_uri(a.url);
-        res[click::Query::ResultKeys::NAME] = a.name;
-        res[click::Query::ResultKeys::DESCRIPTION] = a.description;
-        res[click::Query::ResultKeys::MAIN_SCREENSHOT] = a.main_screenshot;
-        res[click::Query::ResultKeys::INSTALLED] = true;
-        res[click::Query::ResultKeys::VERSION] = a.version;
-        replyProxy->push(res);
-    }
-}
-
-struct click::Query::Private
-{
-    Private(click::Index& index, const scopes::SearchMetadata& metadata)
-        : index(index),
-          meta(metadata)
-    {
-    }
-    click::Index& index;
+        try
+        {
+            if (top_apps_lookup.size() == 0 || top_apps_lookup.find(get_app_identifier(a)) == top_apps_lookup.end())
+            {
+                push_result(cat, a);
+            }
+        }
+        catch (const std::runtime_error &e)
+        {
+            qWarning() << QString::fromStdString(e.what());
+        }
+    }
+}
+
+void click::apps::ResultPusher::push_top_results(
+        const std::vector<click::Application>& apps,
+        const std::string& categoryTemplate)
+{
+    const scopes::CategoryRenderer rdr(categoryTemplate);
+    auto cat = replyProxy->register_category("predefined", "", "", rdr);
+
+    //
+    // iterate over all apps, insert those matching core apps into top_apps_to_push
+    std::map<std::string, click::Application> top_apps_to_push;
+    for (const auto& a: apps)
+    {
+        try
+        {
+            const auto id = get_app_identifier(a);
+            if (top_apps_lookup.find(id) != top_apps_lookup.end())
+            {
+                top_apps_to_push[id] = a;
+                if (core_apps.size() == top_apps_to_push.size())
+                {
+                    // no need to iterate over remaining apps
+                    break;
+                }
+            }
+        }
+        catch (const std::runtime_error &e)
+        {
+            qWarning() << QString::fromStdString(e.what());
+        }
+    }
+
+    //
+    // iterate over core apps and insert them based on top_apps_to_push;
+    // this way the order of core apps is preserved.
+    for (const auto &a: core_apps)
+    {
+        auto const it = top_apps_to_push.find(a);
+        if (it != top_apps_to_push.end())
+        {
+            push_result(cat, it->second);
+        }
+    }
+}
+
+struct click::apps::Query::Private
+{
+    Private(const scopes::SearchMetadata& metadata)
+        : meta(metadata)
+    {
+    }
     scopes::SearchMetadata meta;
+    click::Configuration configuration;
 };
 
-click::Query::Query(unity::scopes::CannedQuery const& query, click::Index& index, scopes::SearchMetadata const& metadata)
+click::apps::Query::Query(unity::scopes::CannedQuery const& query, scopes::SearchMetadata const& metadata)
     : unity::scopes::SearchQueryBase(query, metadata),
-      impl(new Private(index, metadata))
+      impl(new Private(metadata))
 {
 }
 
-void click::Query::cancelled()
+void click::apps::Query::cancelled()
 {
     qDebug() << "cancelling search of" << QString::fromStdString(query().query_string());
 }
 
-click::Query::~Query()
+click::apps::Query::~Query()
 {
     qDebug() << "destroying search";
 }
@@ -165,7 +235,7 @@
 
 }
 
-void click::Query::add_fake_store_app(scopes::SearchReplyProxy const& searchReply)
+void click::apps::Query::add_fake_store_app(scopes::SearchReplyProxy const& searchReply)
 {
     static const std::string title = _("Ubuntu Store");
     static const std::string cat_title = _("Get more apps from the store");
@@ -185,27 +255,28 @@
         res.set_title(title);
         res.set_art(STORE_DATA_DIR "/store-scope-icon.svg");
         res.set_uri(store_scope.to_uri());
-        res[click::Query::ResultKeys::NAME] = title;
-        res[click::Query::ResultKeys::DESCRIPTION] = "";
-        res[click::Query::ResultKeys::MAIN_SCREENSHOT] = "";
-        res[click::Query::ResultKeys::INSTALLED] = true;
-        res[click::Query::ResultKeys::VERSION] = "";
+        res[click::apps::Query::ResultKeys::NAME] = title;
+        res[click::apps::Query::ResultKeys::DESCRIPTION] = "";
+        res[click::apps::Query::ResultKeys::MAIN_SCREENSHOT] = "";
+        res[click::apps::Query::ResultKeys::INSTALLED] = true;
+        res[click::apps::Query::ResultKeys::VERSION] = "";
         searchReply->push(res);
     }
 }
 
-void click::Query::run(scopes::SearchReplyProxy const& searchReply)
+void click::apps::Query::run(scopes::SearchReplyProxy const& searchReply)
 {
+    const std::string categoryTemplate = CATEGORY_APPS_DISPLAY;
     auto querystr = query().query_string();
-    std::string categoryTemplate = CATEGORY_APPS_SEARCH;
+
+    ResultPusher pusher(searchReply, querystr.empty() ? impl->configuration.get_core_apps() : std::vector<std::string>());
+    auto localResults = clickInterfaceInstance().find_installed_apps(querystr);
+
     if (querystr.empty()) {
-        categoryTemplate = CATEGORY_APPS_DISPLAY;
+        pusher.push_top_results(localResults, categoryTemplate);
     }
-    auto localResults = clickInterfaceInstance().find_installed_apps(
-                querystr);
 
-    push_local_results(
-        searchReply,
+    pusher.push_local_results(
         localResults,
         categoryTemplate);
 
 
=== modified file 'scope/clickapps/apps-query.h'
--- scope/clickapps/apps-query.h	2014-05-28 14:27:28 +0000
+++ scope/clickapps/apps-query.h	2014-07-08 07:23:41 +0000
@@ -37,14 +37,19 @@
 
 #include <QSharedPointer>
 #include <set>
+#include <unordered_set>
 
 
 namespace click
 {
 
 class Application;
+class Configuration;
 class Index;
 
+namespace apps
+{
+
 class Query : public scopes::SearchQueryBase
 {
 public:
@@ -60,7 +65,7 @@
         constexpr static const char* VERSION{"version"};
     };
 
-    Query(unity::scopes::CannedQuery const& query, click::Index& index, scopes::SearchMetadata const& metadata);
+    Query(unity::scopes::CannedQuery const& query, scopes::SearchMetadata const& metadata);
     virtual ~Query();
 
     virtual void cancelled() override;
@@ -69,14 +74,32 @@
 
 protected:
     virtual void add_fake_store_app(scopes::SearchReplyProxy const &replyProxy);
-    virtual void push_local_results(scopes::SearchReplyProxy const &replyProxy,
-                                    std::vector<click::Application> const &apps,
-                                    std::string& categoryTemplate);
-
 private:
     struct Private;
     QSharedPointer<Private> impl;
 };
-}
+
+class ResultPusher
+{
+    const scopes::SearchReplyProxy &replyProxy;
+    std::vector<std::string> core_apps;
+    std::unordered_set<std::string> top_apps_lookup;
+
+public:
+    ResultPusher(const scopes::SearchReplyProxy &replyProxy, const std::vector<std::string>& core_apps);
+    virtual ~ResultPusher() = default;
+
+    virtual void push_local_results(const std::vector<click::Application> &apps,
+                                    const std::string& categoryTemplate);
+
+    virtual void push_top_results(
+            const std::vector<click::Application>& apps,
+            const std::string& categoryTemplate);
+protected:
+    virtual void push_result(scopes::Category::SCPtr& cat, const click::Application& a);
+    static std::string get_app_identifier(const click::Application& app);
+};
+} // namespace apps
+} // namespace query
 
 #endif // CLICK_QUERY_H
 
=== modified file 'scope/clickapps/apps-scope.cpp'
--- scope/clickapps/apps-scope.cpp	2014-06-18 16:23:50 +0000
+++ scope/clickapps/apps-scope.cpp	2014-07-08 07:23:41 +0000
@@ -42,6 +42,7 @@
 #include "apps-scope.h"
 #include "apps-query.h"
 
+using namespace click;
 
 click::Scope::Scope()
 {
@@ -78,7 +79,7 @@
 
 scopes::SearchQueryBase::UPtr click::Scope::search(unity::scopes::CannedQuery const& q, scopes::SearchMetadata const& metadata)
 {
-    return scopes::SearchQueryBase::UPtr(new click::Query(q, *index, metadata));
+    return scopes::SearchQueryBase::UPtr(new click::apps::Query(q, metadata));
 }
 
 
 
=== modified file 'scope/tests/CMakeLists.txt'
--- scope/tests/CMakeLists.txt	2014-06-23 15:00:28 +0000
+++ scope/tests/CMakeLists.txt	2014-07-08 07:23:41 +0000
@@ -1,4 +1,5 @@
 set (CLICKSCOPE_TESTS_TARGET click-scope-tests)
+set (APPS_SCOPE_TESTS_TARGET apps-scope-tests)
 find_package(Threads)
 
 # Qt5 bits
@@ -19,7 +20,12 @@
   test_query.cpp
 )
 
+add_executable (${APPS_SCOPE_TESTS_TARGET}
+  test_apps_query.cpp
+)
+
 qt5_use_modules(${CLICKSCOPE_TESTS_TARGET} Core DBus Network Test)
+qt5_use_modules(${APPS_SCOPE_TESTS_TARGET} Core DBus Network Test)
 
 target_link_libraries(${CLICKSCOPE_TESTS_TARGET}
   ${STORE_LIB_UNVERSIONED}
@@ -37,6 +43,22 @@
   ${CMAKE_THREAD_LIBS_INIT}
 )
 
+target_link_libraries(${APPS_SCOPE_TESTS_TARGET}
+  ${APPS_LIB_UNVERSIONED}
+  ${SCOPE_LIB_NAME}
+
+  ${UNITY_SCOPES_LDFLAGS}
+  ${UBUNTUONE_LDFLAGS}
+  ${UBUNTU_DOWNLOAD_MANAGER_CLIENT_LDFLAGS}
+  ${UBUNTU_DOWNLOAD_MANAGER_COMMON_LDFLAGS}
+  ${JSON_CPP_LDFLAGS}
+
+  gmock
+  gmock_main
+
+  ${CMAKE_THREAD_LIBS_INIT}
+)
+
 add_custom_target (test-click-scope
   COMMAND ${CMAKE_CURRENT_BINARY_DIR}/${CLICKSCOPE_TESTS_TARGET}
   DEPENDS ${CLICKSCOPE_TESTS_TARGET}
@@ -56,6 +78,28 @@
   DEPENDS ${CLICKSCOPE_TESTS_TARGET}
 )
 
+# ---
+
+add_custom_target (test-apps-scope
+  COMMAND ${CMAKE_CURRENT_BINARY_DIR}/${APPS_SCOPE_TESTS_TARGET}
+  DEPENDS ${APPS_SCOPE_TESTS_TARGET}
+)
+
+add_custom_target(test-apps-scope-valgrind
+  COMMAND valgrind --tool=memcheck ${CMAKE_CURRENT_BINARY_DIR}/${APPS_SCOPE_TESTS_TARGET}
+  DEPENDS ${APPS_SCOPE_TESTS_TARGET}
+)
+
+add_custom_target(test-apps-scope-leaks
+  COMMAND valgrind --tool=memcheck --track-origins=yes --num-callers=40 --leak-resolution=high --leak-check=full ${CMAKE_CURRENT_BINARY_DIR}/${APPS_SCOPE_TESTS_TARGET}
+  DEPENDS ${APPS_SCOPE_TESTS_TARGET}
+)
+add_custom_target (test-apps-scope-disabled
+  COMMAND GTEST_ALSO_RUN_DISABLED_TESTS=1 ${CMAKE_CURRENT_BINARY_DIR}/${APPS_SCOPE_TESTS_TARGET}
+  DEPENDS ${APPS_SCOPE_TESTS_TARGET}
+)
+
+
 add_subdirectory(integration)
 add_subdirectory(download_manager_tool)
 add_subdirectory(click_interface_tool)
 
=== added file 'scope/tests/test_apps_query.cpp'
--- scope/tests/test_apps_query.cpp	1970-01-01 00:00:00 +0000
+++ scope/tests/test_apps_query.cpp	2014-07-08 07:23:41 +0000
@@ -0,0 +1,84 @@
+/*
+ * Copyright (C) 2014 Canonical Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 3, as published
+ * by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranties of
+ * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+ * PURPOSE.  See the GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * In addition, as a special exception, the copyright holders give
+ * permission to link the code of portions of this program with the
+ * OpenSSL library under certain conditions as described in each
+ * individual source file, and distribute linked combinations
+ * including the two.
+ * You must obey the GNU General Public License in all respects
+ * for all of the code used other than OpenSSL.  If you modify
+ * file(s) with this exception, you may extend this exception to your
+ * version of the file(s), but you are not obligated to do so.  If you
+ * do not wish to do so, delete this exception statement from your
+ * version.  If you delete this exception statement from all source
+ * files in the program, then also delete it here.
+ */
+
+#include <string>
+#include <memory>
+
+#include <gtest/gtest.h>
+#include <gmock/gmock.h>
+
+#include <clickapps/apps-query.h>
+
+#include <unity/scopes/SearchReply.h>
+#include <unity/scopes/testing/MockSearchReply.h>
+
+#include "test_helpers.h"
+
+using namespace click::test::helpers;
+using namespace ::testing;
+
+class ResultPusherTest : public ::testing::Test
+{
+protected:
+    scopes::SearchReplyProxy reply;
+public:
+    ResultPusherTest()
+    {
+        reply.reset(new scopes::testing::MockSearchReply());
+    }
+};
+
+MATCHER_P(HasApplicationTitle, n, "") { return arg["title"].get_string() == n; }
+
+TEST_F(ResultPusherTest, testPushTopAndLocalResults)
+{
+    std::string categoryTemplate("{}");
+    std::vector<click::Application> apps {
+        {"app1", "App1", 0.0f, "icon", "url", "", "sshot"},
+        {"app2", "App2", 0.0f, "icon", "url", "", "sshot"},
+        {"app3", "App3", 0.0f, "icon", "url", "", "sshot"},
+        {"", "App4", 0.0f, "icon", "application:///app4.desktop", "", "sshot"} // a non-click app
+    };
+
+    click::apps::ResultPusher pusher(reply, {"app2", "app4"});
+    auto mockreply = (scopes::testing::MockSearchReply*)reply.get();
+
+    scopes::CategoryRenderer renderer("{}");
+    auto ptrCat = std::make_shared<FakeCategory>("id", "", "", renderer);
+
+    EXPECT_CALL(*mockreply, register_category(_, _, _, _)).WillRepeatedly(Return(ptrCat));
+    EXPECT_CALL(*mockreply, push(Matcher<unity::scopes::CategorisedResult const&>(HasApplicationTitle(std::string("App2")))));
+    EXPECT_CALL(*mockreply, push(Matcher<unity::scopes::CategorisedResult const&>(HasApplicationTitle(std::string("App4")))));
+
+    EXPECT_CALL(*mockreply, push(Matcher<unity::scopes::CategorisedResult const&>(HasApplicationTitle(std::string("App1")))));
+    EXPECT_CALL(*mockreply, push(Matcher<unity::scopes::CategorisedResult const&>(HasApplicationTitle(std::string("App3")))));
+    pusher.push_top_results(apps, categoryTemplate);
+    pusher.push_local_results(apps, categoryTemplate);
+}
+
 
=== added file 'scope/tests/test_helpers.h'
--- scope/tests/test_helpers.h	1970-01-01 00:00:00 +0000
+++ scope/tests/test_helpers.h	2014-07-08 07:23:41 +0000
@@ -0,0 +1,71 @@
+#ifndef TEST_HELPERS_H
+#define TEST_HELPERS_H
+
+#include <click/department-lookup.h>
+#include <click/highlights.h>
+#include "click/index.h"
+#include <click/interface.h>
+#include <click/package.h>
+
+namespace click
+{
+namespace test
+{
+namespace helpers
+{
+static const std::string FAKE_QUERY {"FAKE_QUERY"};
+static const std::string FAKE_CATEGORY_TEMPLATE {"{}"};
+
+
+class MockIndex : public click::Index {
+    click::Packages packages;
+    click::Packages recommends;
+    click::DepartmentList departments;
+    click::DepartmentList bootstrap_departments;
+    click::HighlightList bootstrap_highlights;
+public:
+    MockIndex(click::Packages packages = click::Packages(),
+            click::DepartmentList departments = click::DepartmentList(),
+            click::DepartmentList boot_departments = click::DepartmentList())
+        : Index(QSharedPointer<click::web::Client>()),
+          packages(packages),
+          departments(departments),
+          bootstrap_departments(boot_departments)
+    {
+
+    }
+
+    click::web::Cancellable search(const std::string &query, std::function<void (click::Packages, click::Packages)> callback) override
+    {
+        do_search(query, callback);
+        callback(packages, recommends);
+        return click::web::Cancellable();
+    }
+
+    click::web::Cancellable bootstrap(std::function<void(const click::DepartmentList&, const click::HighlightList&, Error, int)> callback) override
+    {
+        callback(bootstrap_departments, bootstrap_highlights, click::Index::Error::NoError, 0);
+        return click::web::Cancellable();
+    }
+
+    MOCK_METHOD2(do_search,
+                 void(const std::string&,
+                      std::function<void(click::Packages, click::Packages)>));
+};
+
+
+class FakeCategory : public scopes::Category
+{
+public:
+    FakeCategory(std::string const& id, std::string const& title,
+                 std::string const& icon, scopes::CategoryRenderer const& renderer) :
+       scopes::Category(id, title, icon, renderer)
+    {
+    }
+
+};
+} // namespace helpers
+} // namespace test
+} // namespace click
+
+#endif // TEST_HELPERS_H
 
=== modified file 'scope/tests/test_query.cpp'
--- scope/tests/test_query.cpp	2014-06-24 17:18:53 +0000
+++ scope/tests/test_query.cpp	2014-07-08 07:23:41 +0000
@@ -35,8 +35,8 @@
 
 #include "click/qtbridge.h"
 #include "clickstore/store-query.h"
-#include "click/index.h"
 #include "click/application.h"
+#include "test_helpers.h"
 
 #include <tests/mock_network_access_manager.h>
 
@@ -49,51 +49,10 @@
 
 using namespace ::testing;
 using namespace click;
+using namespace click::test::helpers;
 
 namespace
 {
-static const std::string FAKE_QUERY {"FAKE_QUERY"};
-static const std::string FAKE_CATEGORY_TEMPLATE {"{}"};
-
-
-class MockIndex : public click::Index {
-    click::Packages packages;
-    click::Packages recommends;
-    click::DepartmentList departments;
-    click::DepartmentList bootstrap_departments;
-    click::HighlightList bootstrap_highlights;
-
-public:
-    MockIndex(click::Packages packages = click::Packages(),
-            click::DepartmentList departments = click::DepartmentList(),
-            click::DepartmentList boot_departments = click::DepartmentList())
-        : Index(QSharedPointer<click::web::Client>()),
-          packages(packages),
-          departments(departments),
-          bootstrap_departments(boot_departments)
-    {
-
-    }
-
-    click::web::Cancellable search(const std::string &query, std::function<void (click::Packages, click::Packages)> callback) override
-    {
-        do_search(query, callback);
-        callback(packages, recommends);
-        return click::web::Cancellable();
-    }
-
-
-    click::web::Cancellable bootstrap(std::function<void(const click::DepartmentList&, const click::HighlightList&, Error, int)> callback) override
-    {
-        callback(bootstrap_departments, bootstrap_highlights, click::Index::Error::NoError, 0);
-        return click::web::Cancellable();
-    }
-
-    MOCK_METHOD2(do_search,
-                 void(const std::string&,
-                      std::function<void(click::Packages, click::Packages)>));
-};
-
 class MockQueryBase : public click::Query {
 public:
     MockQueryBase(const unity::scopes::CannedQuery& query, click::Index& index,
@@ -140,7 +99,7 @@
 public:
     MockQueryRun(const unity::scopes::CannedQuery& query, click::Index& index,
                  click::DepartmentLookup& depts,
-                 click::HighlightList& highlights, 
+                 click::HighlightList& highlights,
                  scopes::SearchMetadata const& metadata) : MockQueryBase(query, index, depts, highlights, metadata)
     {
 
@@ -154,17 +113,6 @@
                                           std::string& categoryTemplate));
     MOCK_METHOD0(get_installed_packages, PackageSet());
 };
-
-class FakeCategory : public scopes::Category
-{
-public:
-    FakeCategory(std::string const& id, std::string const& title,
-                 std::string const& icon, scopes::CategoryRenderer const& renderer) :
-       scopes::Category(id, title, icon, renderer)
-    {
-    }
-
-};
 } // namespace
 
 TEST(QueryTest, testAddAvailableAppsCallsClickIndex)