Merge lp:~stolowski/unity-lens-applications/preview-on-lmb into lp:unity-lens-applications

[Paweł Stołowski]

Show preview for installable/purchasable applications on activation (i.e. left-mouse-button in the Dash).

Show preview for installable/purchasable applications on activation (i.e. left-mouse-button in the Dash).
All activation requests for unity-install:// uris result in ActivationResponse.with_preview response.

[Michal Hruby (mhr3)]

Looks fine.

review: Approve

[Nick Dedekind (nick-dedekind)]

LGTM.
Passes Manual tests.

review: Approve

=== modified file 'src/daemon.vala'
--- src/daemon.vala	2012-11-30 09:12:34 +0000
+++ src/daemon.vala	2013-02-27 16:21:25 +0000
@@ -1315,11 +1315,16 @@
       string exec_or_dir = null;
       if (uri.has_prefix ("unity-install://"))
       {
-        unowned string pkg = uri.offset (16); // strip off "unity-install://" prefix
-        debug ("Installing: %s", pkg);
-        args = new string[2];
-        args[0] = "software-center";
-        args[1] = pkg;
+        var prv = preview (uri);
+        if (prv != null)
+        {
+          return new Unity.ActivationResponse.with_preview (prv);
+        }
+        else
+        {
+          warning ("Failed to generate preview for %s", uri);
+          return new Unity.ActivationResponse(Unity.HandledType.NOT_HANDLED);
+        }
       }
       else if (uri.has_prefix ("unity-runner://"))
       {

=== modified file 'tests/manual/apps-lens-tests.txt'
--- tests/manual/apps-lens-tests.txt	2012-11-30 09:12:34 +0000
+++ tests/manual/apps-lens-tests.txt	2013-02-27 16:21:25 +0000
@@ -56,3 +56,45 @@
 Expected Result:
 'Recently used', 'Installed', 'More suggestions' categories are displayed.
 The new application is listed in the 'Installed' category (note: this may take a few seconds after installation finished).
+
+Preview activation
+------------------
+LMB activates an application preview for installable/purchasable applications.
+
+Setup:
+Software-Center cache is updated (launch Software-Center at least once).
+
+Actions:
+1. Left-click an application from 'More Suggestions' category of Applications Lens.
+
+Expected Result:
+Application preview is displayed in the Dash, with buttons to download/buy the application and visit developer's site (may not always
+be present if not available).
+
+Preview activation (RMB)
+------------------------
+RMB activates an application preview for all categories of applications (Installed/Recently Used/More Suggestions).
+
+Setup:
+Software-Center cache is updated (launch Software-Center at least once).
+
+Actions:
+1. Right-click an application in any of the Applications Lens categories.
+
+Expected Result:
+Application preview is displayed in the Dash, with buttons to download/buy the application and visit developer's site (may not always
+be present if not available) for installable apps or Uninstall/Launch for installed apps (Uninstall may not be available for some
+important base packages).
+
+Starting applications
+---------------------
+LMB starts an application from Recently Used/Installed category.
+
+Setup:
+Software-Center cache is updated (launch Software-Center at least once).
+
+Actions:
+1. Left-click an application from 'Installed' or 'Recently Used' category of Applications Lens.
+
+Expected Result:
+Application gets started and Dash hides.