Merge lp:~stolowski/unity-lens-applications/download-app-preview-on-lmb into lp:unity-lens-applications

Proposed by Paweł Stołowski
Status: Rejected
Rejected by: Michal Hruby
Proposed branch: lp:~stolowski/unity-lens-applications/download-app-preview-on-lmb
Merge into: lp:unity-lens-applications
Diff against target: 29 lines (+3/-5)
2 files modified
src/daemon.vala (+1/-5)
src/main.vala (+2/-0)
To merge this branch: bzr merge lp:~stolowski/unity-lens-applications/download-app-preview-on-lmb
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michal Hruby Pending
Review via email: mp+122835@code.launchpad.net

Commit message

Request preview on activation of unity-install:// uris.

Description of the change

Request preview on activation of unity-install:// uris.

To post a comment you must log in.
296. By Paweł Stołowski

Set prgname of unity-applications-daemon.

Revision history for this message
Michal Hruby (mhr3) wrote :

Looking good, but dash doesn't behave well with this - the preview navigation is broken if standard activation returns a preview. Should be fixed in unity first.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michal Hruby (mhr3) wrote :

Already fixed.

Unmerged revisions

296. By Paweł Stołowski

Set prgname of unity-applications-daemon.

295. By Paweł Stołowski

Request preview on activation of unity-install:// uris.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/daemon.vala'
--- src/daemon.vala 2012-08-30 11:23:14 +0000
+++ src/daemon.vala 2012-09-05 10:32:19 +0000
@@ -1308,11 +1308,7 @@
1308 string exec_or_dir = null;1308 string exec_or_dir = null;
1309 if (uri.has_prefix ("unity-install://"))1309 if (uri.has_prefix ("unity-install://"))
1310 {1310 {
1311 unowned string pkg = uri.offset (16); // strip off "unity-install://" prefix1311 return new Unity.ActivationResponse(Unity.HandledType.SHOW_PREVIEW);
1312 debug ("Installing: %s", pkg);
1313 args = new string[2];
1314 args[0] = "software-center";
1315 args[1] = pkg;
1316 }1312 }
1317 else if (uri.has_prefix ("unity-runner://"))1313 else if (uri.has_prefix ("unity-runner://"))
1318 {1314 {
13191315
=== modified file 'src/main.vala'
--- src/main.vala 2011-10-04 13:02:38 +0000
+++ src/main.vala 2012-09-05 10:32:19 +0000
@@ -51,6 +51,8 @@
5151
52 public static int main (string[] args)52 public static int main (string[] args)
53 {53 {
54 GLib.Environment.set_prgname ("unity-applications-daemon");
55
54 /* Sort up locale to get translations but also sorting and56 /* Sort up locale to get translations but also sorting and
55 * punctuation right */57 * punctuation right */
56 GLib.Intl.textdomain (Config.PACKAGE);58 GLib.Intl.textdomain (Config.PACKAGE);

Subscribers

People subscribed via source and target branches