Merge lp:~stolowski/unity-lens-applications/binary-name-as-comment into lp:unity-lens-applications

Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: 294
Merged at revision: 294
Proposed branch: lp:~stolowski/unity-lens-applications/binary-name-as-comment
Merge into: lp:unity-lens-applications
Diff against target: 35 lines (+10/-2)
1 file modified
src/daemon.vala (+10/-2)
To merge this branch: bzr merge lp:~stolowski/unity-lens-applications/binary-name-as-comment
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+122081@code.launchpad.net

Commit message

Provide application binary name via comment. Needed by home lens.

Description of the change

Provide application binary name via comment.

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Simple and clean. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/daemon.vala'
--- src/daemon.vala 2012-08-21 13:39:01 +0000
+++ src/daemon.vala 2012-08-30 14:58:28 +0000
@@ -879,6 +879,14 @@
879 });879 });
880 }880 }
881881
882 /**
883 * Sanitize executable name -- make it suitable for Home Lens.
884 */
885 private static string sanitize_binary_name (string name)
886 {
887 return GLib.Path.get_basename (name);
888 }
889
882 private void add_pkg_search_result (Unity.Package.SearchResult results,890 private void add_pkg_search_result (Unity.Package.SearchResult results,
883 Set<string> installed_uris,891 Set<string> installed_uris,
884 Set<string> available_uris,892 Set<string> available_uris,
@@ -918,7 +926,7 @@
918 case Category.APPLICATIONS:926 case Category.APPLICATIONS:
919 installed_uris.add (uri);927 installed_uris.add (uri);
920 display_name = app.get_display_name ();928 display_name = app.get_display_name ();
921 comment = app.get_description ();929 comment = sanitize_binary_name (app.get_executable ());
922 break;930 break;
923 case Category.AVAILABLE:931 case Category.AVAILABLE:
924 available_uris.add (uri);932 available_uris.add (uri);
@@ -1433,7 +1441,7 @@
14331441
1434 results.append (app_uri, app.get_icon().to_string(), category_id,1442 results.append (app_uri, app.get_icon().to_string(), category_id,
1435 "application/x-desktop", app.get_display_name (),1443 "application/x-desktop", app.get_display_name (),
1436 app.get_description (), full_uri);1444 sanitize_binary_name (app.get_executable ()), full_uri);
1437 }1445 }
1438 }1446 }
14391447

Subscribers

People subscribed via source and target branches