Code review comment for lp:~stocks29/do-plugins/scripts

Revision history for this message
Matthew Frizelle (gleebtorin) wrote :

"You're still matching on file extensions, this is no good. What if you just indexed all of the files in a user specified scrips directory, ~/Scripts or something. The list of possible script types is too long to enumerate them all like that, you need a better solution. What about ruby, LOLcode, lua, boo, lisp, php, and the other 10000 scriptings languages that are out there, your plugin should not care what language the script is written in."

Agreed. If you're going to be grouping scripts per type, might I suggest using the binary name as listed in the shebang line? This would result in most, if not all, of the scripts having a human-readable indicator of script type.

« Back to merge proposal