Code review comment for lp:~stocks29/do-plugins/scripts

Revision history for this message
Alex Launi (alexlauni) wrote :

Why is this useful? Maybe I'm missing something but it only handles perl scripts, why not all scripts? Could you just modify the Run in Terminal action to handle parameters? Also, the Name property should be an action, not a name. Yours is "Perl scripts..." something like, "run script" would be more appropriate. line 82 why do you do @"perl"? perl has no special chars in it... My last question is why is the output going to a notification? Generally when a script gives output, it's meaningful and you would want to do something with it. You can't copy from a notification and it may be so long you can't read it. You should return it as a text item so it can be copied to the clipboard or something.

review: Disapprove (community)

« Back to merge proposal