Merge lp:~stijnbrouwers/ubuntu/quantal/kamoso/fix-thumbnails into lp:ubuntu/raring/kamoso
Status: | Work in progress | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~stijnbrouwers/ubuntu/quantal/kamoso/fix-thumbnails | ||||
Merge into: | lp:ubuntu/raring/kamoso | ||||
Diff against target: |
57 lines (+37/-0) 3 files modified
debian/changelog (+16/-0) debian/patches/fix-thumbnails.patch (+20/-0) debian/patches/series (+1/-0) |
||||
To merge this branch: | bzr merge lp:~stijnbrouwers/ubuntu/quantal/kamoso/fix-thumbnails | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher | Pending | ||
Ubuntu branches | Pending | ||
Review via email: mp+137246@code.launchpad.net |
This proposal supersedes a proposal from 2012-11-22.
Description of the change
This patch fixes the bug which makes all thumbnails show up as red rectangles
Unmerged revisions
- 22. By Stijn Brouwers
-
changed the target vcs from quantal to raring
- 21. By Stijn Brouwers
-
debian/
patches/ fix-thumbnails. patch:
Problem : The thumbnails are shown as red rectangles (LP: #1074958)
Solution : dropped some code.
Explanation of the code dropped:
The code checked a parameter named 'showDecorationSelected' .
judging by the name of the parameter and the functionality, when-
ever a thumbnail is selected, a red rectangle should show behind it.
However, the z-index is not correct (seems to be on top of the image),
and the parameter is not applied correctly (to every thumbnail instead
of only the selected). Because there is already some basic selection,
I just dropped the code that sets the red rectangle. - 20. By Stijn Brouwers
-
debian/
patches/ fix-thumbnails. patch: Fix the bug which makes thumbnails
show as red rectangles. (LP: #1074958)
Thank you for your work, is that issue reported upstream? Could you update the patch with to file the infos Description/ Origin/ Bug? Could you also explain what's the issue with the code that are dropping? It was probably added for a reason so it would be good to have some details on why it's not needed anymore and why it's creating issues