Code review comment for lp:~stgraber/upstart/upstart-session-socket

Revision history for this message
James Hunt (jamesodhunt) wrote :

Hi Stéphane,

* init/control.c:
  - control_init(): Second call to nih_strcat_sprintf() should be
    nih_strcat() or nih_strdup().
* util/tests/test_initctl.c: Still need a test for 'init --user'.

review: Needs Fixing

« Back to merge proposal