Code review comment for lp:~stgraber/upstart/upstart-initgroups

Revision history for this message
James Hunt (jamesodhunt) wrote :

Thanks for this. Great that we now have some form of test for this scenario. Just a couple of points:

* init/tests/test_job_process.c:
  - Can you change the getpwuid() call to getpwnam ("nobody") and
    likewise for getgrgid() to getgrnam() as it's much clearer and
    should protect us in the case where the tests are run on
    systems with 32-bit uid_t's. This will also solve the 2 typo issues
    (655534 rather than 65534).
  - Also, can you put some more comments on that test to make it clear
    why it is expected to work when run as "nobody".

« Back to merge proposal