Code review comment for lp:~stgraber/ubuntu/trusty/systemd/logind-cgmanager

Revision history for this message
Martin Pitt (pitti) wrote :

> Branch updated to add the missing free().

Thanks. As I said, using _cleanup_free is much simpler and less error prone for cases like this, but it looks correct to me now.

LGTM now.

> Is there a bug report for this? I suppose this needs an FFE and proper testing at this point of the release cycle.

This is still an open question. When you upload it would be nice to refer to that bug.

Thanks!

review: Approve

« Back to merge proposal