mtp

Merge lp:~stgraber/mtp/upstart-fixes into lp:mtp

Proposed by Stéphane Graber
Status: Merged
Approved by: Francis Ginther
Approved revision: 33
Merged at revision: 33
Proposed branch: lp:~stgraber/mtp/upstart-fixes
Merge into: lp:mtp
Diff against target: 47 lines (+10/-4)
3 files modified
debian/changelog (+9/-0)
debian/mtp-server.conf (+1/-2)
debian/mtp-server.mtp-server-bootup.upstart (+0/-2)
To merge this branch: bzr merge lp:~stgraber/mtp/upstart-fixes
Reviewer Review Type Date Requested Status
Oliver Grawert Approve
PS Jenkins bot continuous-integration Approve
Loïc Minier Approve
Review via email: mp+187587@code.launchpad.net

Commit message

Fix some upstart issues.

Description of the change

Fix some upstart issues.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Loïc Minier (lool) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
Oliver Grawert (ogra) wrote :

looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-09-18 14:38:45 +0000
+++ debian/changelog 2013-09-25 19:41:58 +0000
@@ -1,3 +1,12 @@
1mtp (0.0.1+13.10.20130918-0ubuntu2) UNRELEASED; urgency=low
2
3 * Fix upstart jobs. The system job was marked as task but wasn't a
4 task and was therefore keeping lxc-android-config in post-start. The
5 user job was working fine, but was backgrounding the process on the exec
6 line instead of just letting upstart track it directly.
7
8 -- Stéphane Graber <stgraber@ubuntu.com> Wed, 25 Sep 2013 15:39:21 -0400
9
1mtp (0.0.1+13.10.20130918-0ubuntu1) saucy; urgency=low10mtp (0.0.1+13.10.20130918-0ubuntu1) saucy; urgency=low
211
3 [ Oliver Grawert ]12 [ Oliver Grawert ]
413
=== modified file 'debian/mtp-server.conf'
--- debian/mtp-server.conf 2013-09-10 15:55:18 +0000
+++ debian/mtp-server.conf 2013-09-25 19:41:58 +0000
@@ -2,7 +2,6 @@
22
3start on :sys:android_usb-device-changed3start on :sys:android_usb-device-changed
44
5expect fork
6respawn5respawn
76
8pre-start script7pre-start script
@@ -15,4 +14,4 @@
15 rm -f ~/.cache/upstart/mtp-server.log14 rm -f ~/.cache/upstart/mtp-server.log
16end script15end script
1716
18exec /usr/bin/mtp-server &17exec /usr/bin/mtp-server
1918
=== modified file 'debian/mtp-server.mtp-server-bootup.upstart'
--- debian/mtp-server.mtp-server-bootup.upstart 2013-09-18 14:08:04 +0000
+++ debian/mtp-server.mtp-server-bootup.upstart 2013-09-25 19:41:58 +0000
@@ -3,8 +3,6 @@
3start on android3start on android
4stop on runlevel [06]4stop on runlevel [06]
55
6task
7
8emits android_usb-device-changed6emits android_usb-device-changed
97
10pre-start script8pre-start script

Subscribers

People subscribed via source and target branches