Code review comment for lp:~stewart/percona-server/pkg-5.5

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

> > - build/debian/rules have diverged from the old build-dpkg.sh and
> > from the old/current build-binary.sh in server CMake options at
> > least in one instance: -DWITH_SSL=bundled, although we have
> > switched to -DWITH_SSL=system. Was that intentional? If no, how
> > can we ensure that our CMake options are in sync across all the
> > packaging options? If yes, how do we handle the diverging CMake
> > options across platforms?
>
> for debian, you have to use =system as per Debian policy.

So currently build-ps/debian/rules has -DWITH_SSL=bundled and that needs fixing, right?

review: Needs Fixing

« Back to merge proposal