Code review comment for lp:~stewart/drizzle/embedded-innodb-enum-type

So are you in agreement enough to change the code to be a constant? :)

-jay

On Mon, May 10, 2010 at 10:02 PM, Stewart Smith
<email address hidden> wrote:
>> Hi!
>>
>> 21      + assert(field_options.field_value_size() < (int)0x10000);
>>
>> really? A constant would be nice for those of us which speak Hex as a second
>> language ;)
>
> Ahhh... but that would just be the limit for how many enum items we can have (one higher than 0xFFFF)... I'd like their to be an interface too (or at least the engines be able to trust it).
> --
> https://code.launchpad.net/~stewart-flamingspork/drizzle/embedded-innodb-enum-type/+merge/23825
> You are reviewing the proposed merge of lp:~stewart-flamingspork/drizzle/embedded-innodb-enum-type into lp:drizzle.
>