Merge ~steverydz/maas:ipmi-disabled-form into maas:master

[Steve Rydz]

LP: #1837210 - Fix machine config form diabled if no mac address

Done:
- Add an array of optional keys
- Check if key is in optional keys and return true if that's the case

QA:
- Go to a machine that has a power type of IPMI (tested on karura)
- In the configuration tab edit the power configuration form
- Remove the value from the Power MAC field
- See that you are able to save the form

[MAAS Lander (maas-lander)]

UNIT TESTS
-b ipmi-disabled-form lp:~steverydz/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: cad0ed550ea86606a7bf78b8e57be566760509d2

review: Approve

[Caleb Ellis (caleb-ellis)]

Incredibly minor, non-blocking comments but otherwise good to go.

review: Approve

diff --git a/src/maasserver/static/js/angular/controllers/node_details.js b/src/maasserver/static/js/angular/controllers/node_details.js
index 2c986dd..f08f6d2 100644
--- a/src/maasserver/static/js/angular/controllers/node_details.js
+++ b/src/maasserver/static/js/angular/controllers/node_details.js
@@ -1272,10 +1272,17 @@ function NodeDetailsController(
       return false;
     }
 
+    // Keys which are optional
+    const optionalKeys = ["mac_address"];
+
     // If keys but no values in obj
     var hasParameters = false;
 
     Object.keys(power_parameters).forEach(function(key) {
+      if (optionalKeys.includes(key)) {
+        return true;
+      }
+
       if (power_parameters[key] !== "") {
         hasParameters = true;
       } else {
diff --git a/src/maasserver/static/js/angular/controllers/tests/test_node_details.js b/src/maasserver/static/js/angular/controllers/tests/test_node_details.js
index 81d1f91..9f1e16a 100644
--- a/src/maasserver/static/js/angular/controllers/tests/test_node_details.js
+++ b/src/maasserver/static/js/angular/controllers/tests/test_node_details.js
@@ -2551,5 +2551,16 @@ describe("NodeDetailsController", function() {
         })
       ).toBe(true);
     });
+
+    it("returns true if optional power_parameters are empty", function() {
+      makeController();
+      expect(
+        $scope.powerParametersValid({
+          power_address: "qemu+ssh://ubuntu@172.16.3.247/system",
+          power_id: 26,
+          mac_address: ""
+        })
+      ).toBe(true);
+    });
   });
 });