Merge ~steverydz/maas:1827155-multiple-machine-deploy-error into maas:master

[Steve Rydz]

LP: #1827155 - Fix error display when deploying multiple machines

Done:
- Prevented the error from disappearing due to page refresh when deploying two or more machines
- Some minor eslint fixes
- Ran prettier

QA:
- Go to machines list
- Check all machines
- From the "Take action" menu click "Deploy"
- Update your selection so only deployable machines are selected
- Click the deploy button
- See that an error is displayed and it persists until you press the "Cancel" button

Screenshot: https://images.zenhubusercontent.com/5a9d4ee34b5806bc2bc9694d/14258181-b839-4b55-951f-52d9076d8f02

[Caleb Ellis (caleb-ellis)]

LGTM!

review: Approve

[MAAS Lander (maas-lander)]

LANDING
-b 1827155-multiple-machine-deploy-error lp:~steverydz/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED MERGE
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-lander/436163/console

diff --git a/src/maasserver/static/js/angular/controllers/nodes_list.js b/src/maasserver/static/js/angular/controllers/nodes_list.js
index f4214d4..4434e03 100644
--- a/src/maasserver/static/js/angular/controllers/nodes_list.js
+++ b/src/maasserver/static/js/angular/controllers/nodes_list.js
@@ -157,7 +157,7 @@ function NodesListController(
   $scope.tabs.pools.isPoolAction = function(pool, action) {
     let tab = $scope.tabs.pools;
     return (
-      (action === undefined || tab.activeTargetAction === action) &&
+      (angular.isUndefined(action) || tab.activeTargetAction === action) &&
       tab.activeTarget !== null &&
       tab.activeTarget.id === pool.id
     );
@@ -252,8 +252,8 @@ function NodesListController(
   $scope.tabs.controllers.newPool = {};
   $scope.tabs.controllers.syncStatuses = {};
   $scope.tabs.controllers.addController = false;
-  $scope.tabs.controllers.registerUrl = MAAS_config.register_url;
-  $scope.tabs.controllers.registerSecret = MAAS_config.register_secret;
+  $scope.tabs.controllers.registerUrl = $window.MAAS_config.register_url;
+  $scope.tabs.controllers.registerSecret = $window.MAAS_config.register_secret;
 
   // Switch tab.
   $scope.tabs.switches = {};
@@ -796,7 +796,10 @@ function NodesListController(
       // Set the zone parameter.
       extra.zone_id = tab.zoneSelection.id;
     } else if (tab.actionOption.name === "set-pool") {
-      if (tab.poolAction === "create-pool" && tab.newPool.name !== undefined) {
+      if (
+        tab.poolAction === "create-pool" &&
+        angular.isDefined(tab.newPool.name)
+      ) {
         // Create the pool and set the action options with
         // the new pool id.
         preAction = ResourcePoolsManager.createItem({
@@ -929,15 +932,14 @@ function NodesListController(
             function() {
               tab.actionProgress.completed += 1;
               node.action_failed = false;
-              updateSelectedItems(tabName);
             },
             function(error) {
               addErrorToActionProgress(tabName, error, node);
               node.action_failed = true;
-              updateSelectedItems(tabName);
             }
           );
         });
+        updateSelectedItems(tabName);
       },
       function(error) {
         addErrorToActionProgress(tabName, error);
diff --git a/src/maasserver/static/partials/nodes-list.html b/src/maasserver/static/partials/nodes-list.html
index e1fcde0..16bd5c3 100644
--- a/src/maasserver/static/partials/nodes-list.html
+++ b/src/maasserver/static/partials/nodes-list.html
@@ -422,8 +422,12 @@
                         {$ tabs[tab].actionProgress.completed $} of {$ tabs[tab].actionProgress.total $}
                         nodes are transitioning to {$ tabs[tab].actionOption.sentence $}.
                     </p>
-                    <div data-ng-repeat="(error, machines) in tabs[tab].actionProgress.errors">
-                        <span class="p-icon--error">Error: </span> The {$ tabs[tab].actionOption.title.toLowerCase() $} action for {$ nodes.length $} <span data-ng-pluralize count="nodes.length" when="{'one': 'node', 'other': 'nodes'}"></span> failed with error: {$ error $}
+                    <div class="p-notification--negative" data-ng-repeat="(error, machines) in tabs[tab].actionProgress.errors">
+                        <p class="p-notification__response">
+                            <span class="p-notification__status">Error: </span> The {$ tabs[tab].actionOption.title.toLowerCase() $} action for {$
+                            nodes.length $} <span data-ng-pluralize count="nodes.length" when="{'one': 'node', 'other': 'nodes'}"></span> failed
+                            with error: {$ error $}
+                        </p>
                     </div>
                 </div>
             </section>