Code review comment for lp:~stevenwilkin/snapweb/add-remove-snaps-via-api

The attempt to merge lp:~stevenwilkin/webdm/add-remove-snaps-via-api into lp:webdm failed. Below is the output from the failed tests.

Checking formatting
Installing godeps
Install golint
Obtaining dependencies
update github.com/cheggaaa/pb failed; trying to fetch newer version
github.com/cheggaaa/pb now at e8c7cc515bfde3e267957a3b110080ceed51354e
update golang.org/x/crypto failed; trying to fetch newer version
golang.org/x/crypto now at 60052bd85f2d91293457e8811b0cf26b773de469
update github.com/davecheney/mdns failed; trying to fetch newer version
github.com/davecheney/mdns now at de174d86a3d3e87bfad9cb66cedd0433380b67b0
update github.com/gorilla/context failed; trying to fetch newer version
github.com/gorilla/context now at 50c25fb3b2b3b3cc724e9b6ac75fb44b3bccd0da
update github.com/gorilla/mux failed; trying to fetch newer version
github.com/gorilla/mux now at e444e69cbd2e2e3e0749a2f3c717cec491552bbf
update github.com/gosexy/gettext failed; trying to fetch newer version
github.com/gosexy/gettext now at 98b7b91596d20b96909e6b60d57411547dd9959c
update github.com/mvo5/uboot-go failed; trying to fetch newer version
github.com/mvo5/uboot-go now at 69978a3e4b05cca9d7cfee489b3453dfed45e72c
update gopkg.in/yaml.v2 failed; trying to fetch newer version
gopkg.in/yaml.v2 now at 49c95bdc21843256fb6c4e0d370a05f24a0bf213
update gopkg.in/check.v1 failed; trying to fetch newer version
gopkg.in/check.v1 now at 64131543e7896d5bcc6bd5a76287eb75ea96c673
update github.com/davecheney/gmx failed; trying to fetch newer version
github.com/davecheney/gmx now at d765420e7fbaccecb2a38cf2a02701fe3e0888a3
update github.com/mvo5/goconfigparser failed; trying to fetch newer version
github.com/mvo5/goconfigparser now at 26426272dda20cc76aa1fa44286dc743d2972fe8
update github.com/miekg/dns failed; trying to fetch newer version
github.com/miekg/dns now at 5a357a6fc5e85268b929350aa6423e2d56dcc4ff
update github.com/ubuntu-core/snappy failed; trying to fetch newer version
github.com/ubuntu-core/snappy now at 5bcb20229bb884b85144eab0fe5db7aa05a27ebf
Building
Running tests from /mnt/tarmac/tmp/tmp.RkPg752sU4/src/launchpad.net/webdm
=== RUN Test
OK: 4 passed
--- PASS: Test (0.00s)
PASS
coverage: 60.0% of statements
ok launchpad.net/webdm/avahi 0.012s coverage: 60.0% of statements
? launchpad.net/webdm/cmd/snappyd [no test files]
=== RUN Test
WARNING: cannot create /mnt/tarmac/tmp/check-4282530047168441630/1/badDataPath/icons
OK: 17 passed
--- PASS: Test (0.02s)
PASS
coverage: 46.8% of statements
ok launchpad.net/webdm/snappy 0.029s coverage: 46.8% of statements
=== RUN Test
OK: 8 passed
--- PASS: Test (0.41s)
PASS
coverage: 100.0% of statements
ok launchpad.net/webdm/statustracker 0.414s coverage: 100.0% of statements
Running vet
Running lint
Obtaining npm dependencies

# we always run in a fresh dir in tarmac
export GOPATH=$(mktemp -d -p /mnt/tarmac/tmp); export TMPDIR=/mnt/tarmac/tmp
trap 'rm -rf "$GOPATH"' EXIT

# this is a hack, but not sure tarmac is golang friendly
mkdir -p $GOPATH/src/launchpad.net/webdm
cp -a . $GOPATH/src/launchpad.net/webdm/
cd $GOPATH/src/launchpad.net/webdm

./run-checks
github.com/davecheney/gmx
github.com/miekg/dns
github.com/gorilla/context
github.com/gorilla/mux
github.com/ubuntu-core/snappy/dirs
github.com/ubuntu-core/snappy/logger
github.com/ubuntu-core/snappy/helpers
golang.org/x/crypto/cast5
golang.org/x/crypto/openpgp/elgamal
golang.org/x/crypto/openpgp/errors
golang.org/x/crypto/openpgp/s2k
golang.org/x/crypto/openpgp/packet
github.com/ubuntu-core/snappy/asserts
github.com/davecheney/mdns
launchpad.net/webdm/avahi
gopkg.in/yaml.v2
github.com/ubuntu-core/snappy/client
github.com/ubuntu-core/snappy/arch
github.com/ubuntu-core/snappy/systemd
github.com/gosexy/gettext
github.com/ubuntu-core/snappy/i18n
github.com/ubuntu-core/snappy/oauth
github.com/mvo5/goconfigparser
github.com/ubuntu-core/snappy/snap
github.com/ubuntu-core/snappy/coreconfig
github.com/mvo5/uboot-go/uenv
github.com/ubuntu-core/snappy/partition
github.com/ubuntu-core/snappy/policy
github.com/cheggaaa/pb
github.com/ubuntu-core/snappy/provisioning
github.com/ubuntu-core/snappy/release
github.com/ubuntu-core/snappy/snap/remote
github.com/ubuntu-core/snappy/snap/squashfs
github.com/ubuntu-core/snappy/progress
github.com/ubuntu-core/snappy/timeout
launchpad.net/webdm/statustracker
github.com/ubuntu-core/snappy/snappy
launchpad.net/webdm/snappy
launchpad.net/webdm/cmd/snappyd
npm ERR! Error: ENOSPC, open '/home/ubuntu/.npm/912f2740-autoprefixer-core-5-1-11.lock'
npm ERR! If you need help, you may report this log at:
npm ERR! <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR! <email address hidden>

npm ERR! System Linux 3.19.0-58-generic
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install" "--loglevel" "error"
npm ERR! cwd /mnt/tarmac/tmp/tmp.RkPg752sU4/src/launchpad.net/webdm
npm ERR! node -v v0.10.25
npm ERR! npm -v 1.3.10
npm ERR! path /home/ubuntu/.npm/912f2740-autoprefixer-core-5-1-11.lock
npm ERR! code ENOSPC
npm ERR! errno 54
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR! /mnt/tarmac/tmp/tmp.RkPg752sU4/src/launchpad.net/webdm/npm-debug.log
npm ERR! not ok code 0