Code review comment for lp:~stevenk/launchpad/queue-no-changes

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Thursday 14 July 2011 11:16:30 you wrote:
> > 8 + if not changesfile_object:
> >
> > This violates our coding style, using "is not None" if you mean that.
>
> Not anymore. We fixed that in Texas.
> "Truth conditionals
> Remember that False, None, [], and 0 are not the same although they
> all evaluate to False in a boolean context. If this matters in your
> code, be sure to check explicitly for either of them.

Why was this not advertised more widely?

« Back to merge proposal