Code review comment for lp:~stevenk/launchpad/queue-no-changes

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Thanks for making this fix Steve. Just a couple of small suggestions:

8 + if not changesfile_object:

This violates our coding style, using "is not None" if you mean that.

22 + if self.changesfile:

Same thing here.

Also you need an extra unit test for the notify() change.

review: Needs Fixing

« Back to merge proposal