Thanks for making this fix Steve. Just a couple of small suggestions:
8 + if not changesfile_object:
This violates our coding style, using "is not None" if you mean that.
22 + if self.changesfile:
Same thing here.
Also you need an extra unit test for the notify() change.
« Back to merge proposal
Thanks for making this fix Steve. Just a couple of small suggestions:
8 + if not changesfile_object:
This violates our coding style, using "is not None" if you mean that.
22 + if self.changesfile:
Same thing here.
Also you need an extra unit test for the notify() change.